Draft: Revert common caching strategy which was not working at scale#180
Closed
padelsbach wants to merge 1 commit into
Closed
Draft: Revert common caching strategy which was not working at scale#180padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
padelsbach
changed the title
padelsbach
force-pushed
the
wp_revert_cache
branch
10 times, most recently
from
918a999 to
bb3c60c
Compare
aidangarske
reviewed
Jun 18, 2025
padelsbach
force-pushed
the
wp_revert_cache
branch
8 times, most recently
from
d9b1bca to
9382e98
Compare
padelsbach
force-pushed
the
wp_revert_cache
branch
from
9382e98 to
6be8776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple limitations with github actions....
First is that the caches aren't visible across branches -- with some exceptions if the cache was created on the main branch.
Second is that they don't guard against race conditions where multiple jobs access the cache. And the result is a corrupted cache entry or unexpected cache hit/miss