Define package dependency to host HTML resources #271
+284
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
mokagio/ship-resources-as-xcframework
branch
from
9a85ac2 to
a922952
Compare
This setup worked in a different configuration, not sure why it doesn't here yet.
This had been in my local setup all this time, but got lost in the many `ios/Sources` diff lines
mokagio
force-pushed
the
mokagio/ship-resources-as-xcframework
branch
from
71a0dc2 to
6cbc42a
Compare
Otherwise, we get error: 'gutenbergkit': invalid type for binary product 'GutenbergKit'; products referencing only binary targets must be executable or automatic library products
When GutenbergKitResources is a binary target (XCFramework), Swift fails with "module was built from a non-package interface" because it treats both targets as same-package but the XCFramework was built for distribution. Setting packageAccess: false makes GutenbergKit act as an external client, bypassing the same-package module loading restriction. See: https://developer.apple.com/documentation/packagedescription/target/packageaccess 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The `packageAccess: false` setting required for XCFramework import is incompatible with Swift's `package` access modifier. When packageAccess is disabled, the compiler doesn't pass -package-name, causing `package` declarations to be treated as fileprivate. This is a necessary tradeoff to support XCFramework distribution. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update the build script to name the zip archive as: GutenbergKitResources-<commit_sha>.xcframework.zip This matches the URL format expected in Package.swift for versioned XCFramework distribution. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Move checksum computation from Makefile into build_xcframework.sh to keep SHA knowledge in one place (DRY) - Replace emoji output with green colored text - Move color definitions to top of script 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Accessibility Testing Instructions
Screenshots or screencast