feat(oagen[3/3]): Add remaining generated serializers, fixtures, and specs#1537
Closed
gjtorikian wants to merge 0 commit intooagen/2/modified-apis-existing-filesfrom
Closed
feat(oagen[3/3]): Add remaining generated serializers, fixtures, and specs#1537gjtorikian wants to merge 0 commit intooagen/2/modified-apis-existing-filesfrom
gjtorikian wants to merge 0 commit intooagen/2/modified-apis-existing-filesfrom
Conversation
ffdf6c6 to
2e86434
Compare
2e86434 to
c9684b5
Compare
Contributor
Author
|
this output was a mistake and could have been vastly reduced into just #1536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the companion to PR #1536. That PR included only the generated files that are transitively imported by modified service code. This PR adds everything else the generator produced: 285 files that are not yet imported by any service method but exist to complete the SDK's type coverage.
What's in here and why
The generator creates a full set of artifacts for every schema in the OpenAPI spec, regardless of whether the current SDK code uses it yet. That means:
103 serializers —
serialize*anddeserialize*functions for API objects that don't yet have service methods calling them. For example,audit-log-event.serializer.tscan serialize/deserialize the full audit log event shape, even thoughaudit-logs.tscurrently only exposescreateEventandcreateExport. These become useful as we wire up additional endpoints.13 interfaces — standalone types that aren't imported by anything in PR #1536. Things like
Role,RoleList,AuditLogSchema,DirectoryUserWithGroups—types the API returns but that no existing SDK method currently deserializes into.6 spec files — tests for the six new user-management sub-services introduced in PR #1536 (CORS origins, JWT templates, redirect URIs, session tokens, authorized applications, data providers). These import fixture JSON files to mock API responses.
163 fixture files —
.fixture.jsonfiles used by the specs above and by future tests. Each one is a representative JSON response for an API object, pulled from the OpenAPI spec examples.Why a separate PR
PR #1536 is the one to scrutinize—it modifies existing behavior, adds new service classes, and wires things into
workos.ts. This PR is purely additive: new files that nothing currently imports (except the specs, which test the sub-services from #1536). Splitting it out keeps the review surface manageable and lets a reviewer skim this one quickly while focusing attention on #1536.Note: this is the third of three PRs, after #1535 (new services) and #1536 (existing service updates).