Skip to content

feat(oagen[3/3]): Add remaining generated serializers, fixtures, and specs#1537

Closed
gjtorikian wants to merge 0 commit intooagen/2/modified-apis-existing-filesfrom
oagen/2/modified-apis-new-models
Closed

feat(oagen[3/3]): Add remaining generated serializers, fixtures, and specs#1537
gjtorikian wants to merge 0 commit intooagen/2/modified-apis-existing-filesfrom
oagen/2/modified-apis-new-models

Conversation

@gjtorikian
Copy link
Copy Markdown
Contributor

@gjtorikian gjtorikian commented Mar 26, 2026

Description

This is the companion to PR #1536. That PR included only the generated files that are transitively imported by modified service code. This PR adds everything else the generator produced: 285 files that are not yet imported by any service method but exist to complete the SDK's type coverage.

What's in here and why

The generator creates a full set of artifacts for every schema in the OpenAPI spec, regardless of whether the current SDK code uses it yet. That means:

103 serializersserialize* and deserialize* functions for API objects that don't yet have service methods calling them. For example, audit-log-event.serializer.ts can serialize/deserialize the full audit log event shape, even though audit-logs.ts currently only exposes createEvent and createExport. These become useful as we wire up additional endpoints.

13 interfaces — standalone types that aren't imported by anything in PR #1536. Things like Role, RoleList, AuditLogSchema, DirectoryUserWithGroups—types the API returns but that no existing SDK method currently deserializes into.

6 spec files — tests for the six new user-management sub-services introduced in PR #1536 (CORS origins, JWT templates, redirect URIs, session tokens, authorized applications, data providers). These import fixture JSON files to mock API responses.

163 fixture files.fixture.json files used by the specs above and by future tests. Each one is a representative JSON response for an API object, pulled from the OpenAPI spec examples.

Why a separate PR

PR #1536 is the one to scrutinize—it modifies existing behavior, adds new service classes, and wires things into workos.ts. This PR is purely additive: new files that nothing currently imports (except the specs, which test the sub-services from #1536). Splitting it out keeps the review surface manageable and lets a reviewer skim this one quickly while focusing attention on #1536.

Note: this is the third of three PRs, after #1535 (new services) and #1536 (existing service updates).

@gjtorikian gjtorikian requested review from a team as code owners March 26, 2026 20:29
@gjtorikian gjtorikian requested review from nicknisi and removed request for a team March 26, 2026 20:29
@gjtorikian gjtorikian changed the title feat(oagen): add remaining generated models, serializers, and fixtures feat(oagen[3/3]): add remaining generated models, serializers, and fixtures Mar 26, 2026
@gjtorikian gjtorikian force-pushed the oagen/2/modified-apis-new-models branch from ffdf6c6 to 2e86434 Compare March 26, 2026 20:34
@gjtorikian gjtorikian changed the title feat(oagen[3/3]): add remaining generated models, serializers, and fixtures feat(oagen[3/3]): Add remaining generated serializers, fixtures, and specs Mar 26, 2026
@gjtorikian gjtorikian closed this Mar 26, 2026
@gjtorikian gjtorikian force-pushed the oagen/2/modified-apis-new-models branch from 2e86434 to c9684b5 Compare March 26, 2026 20:49
@gjtorikian
Copy link
Copy Markdown
Contributor Author

this output was a mistake and could have been vastly reduced into just #1536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant