Skip to content

CMake DA Core#2092

Open
islas wants to merge 24 commits intowrf-model:developfrom
islas:cmake-da
Open

CMake DA Core#2092
islas wants to merge 24 commits intowrf-model:developfrom
islas:cmake-da

Conversation

@islas
Copy link
Collaborator

@islas islas commented Aug 6, 2024

TYPE: enhancement

KEYWORDS: cmake, da

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
The current CMake build does not support building the DA core

Solution:
Allow the selection and building of the DA core. Some minor changes to source code were made to facilitate the compilation without resorting to in situ file rewrites with sed. These changes fix compilation errors with iargc intrinsic function in gfortran but still allow the original make / cpp preprocessing to work as originally done.

A notable difference to the original DA build is that no source code is copied or duplicated into the folders. Instead in the respective folders used for shared source code between cores if a DA build is requested only select files are compiled. Otherwise the full set of files in those directories is used.

Additionally, WAVELET, CRTM, and BUFR can be selected as CMake options (not environment variables). All are defaulted to on in this iteration.

@islas islas requested review from a team as code owners August 6, 2024 03:44
@islas
Copy link
Collaborator Author

islas commented Aug 6, 2024

Requires #2056, #2053, #2086, #2087, #2088, #2090, and #2091

@islas islas changed the base branch from master to release-v4.6.1 August 6, 2024 03:45
@amstokely amstokely self-requested a review November 14, 2025 18:54
@islas islas requested a review from a team as a code owner January 12, 2026 22:08
@islas islas changed the base branch from release-v4.6.1 to develop January 13, 2026 19:57
@islas islas requested review from mgduda and removed request for a team January 13, 2026 19:58
@islas
Copy link
Collaborator Author

islas commented Jan 26, 2026

@dudhia or @weiwangncar Do you either of you have any recommendations for who to sign off on the minor DA code changes?

@dudhia
Copy link
Collaborator

dudhia commented Jan 26, 2026

@dudhia or @weiwangncar Do you either of you have any recommendations for who to sign off on the minor DA code changes?

That would be @liujake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants