Open
Conversation
When PnetCDF is configured to use netCDF, the find module will appropriately locate this netCDF if possible to identify via pnetcdf-config information, but the current built then continues to find netCDF-Fortran. This may be co-located with a different version of netCDF which may result in conflicting linking of the netCDF library where used.
islas
force-pushed
the
cmake-pnetcdf
branch
from
cfb49eb to
762515a
Compare
amstokely
approved these changes
Nov 14, 2025
dudhia
approved these changes
Dec 12, 2025
Collaborator
Author
|
When you can, @mgduda could you review this PR for secondary approval? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: cmake, pnetcdf
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
The CMake build does not support PnetCDF detection and thus the
external/io_pnetcdf/code cannot be built.Solution:
Write a FindPnetCDF.cmake package that provides the appropriate imported target to link against and does precursory library matching if there is a dependency on netCDF C. Update the cmake code in
external/io_pnetcdf/to build, with minor adjustments that make the CMake and Make builds compatible.The package uses the same rules of the netCDF packages, utilizing
pnetcdf-configin thePATHas the source of information, or otherwise found via standardfind_package()mechanics, e.g.PnetCDF_ROOT.TESTS CONDUCTED:
RELEASE NOTE: CMake PnetCDF Find Package