Implementation of MYNN-EDMF submodule #2148

joeolson42 · 2024-12-31T21:16:51Z

This replaces the original (non submodule) MYNN with the public-facing MYNN-EDMF submodule, which will the central point of development for the MYNN-EDMF in WRF, MPAS, and CCPP.

TYPE: bug fix, enhancement, and new feature

KEYWORDS: refactored, submodule, MYNN-EDMF

SOURCE: Joseph Olson (NOAA/GSL)

DESCRIPTION OF CHANGES:

Submodule implementation pointing to https://github.com/NCAR/MYNN-EDMF/
This is a refactored scheme (now k-only) which is called from a new driver derived heavily from the MPAS driver.
The module names changed from mynn to mynnedmf to resolve a version conflict in MPAS.
This version carries many modification that originated in FV3-related development for RRFSv1, but it has since been tuned to better perform in MPAS and WRF, unlike previous versions of the MYNN. The list of modifications are fairly extensive but the most dycore-sensitive parts of the MYNN are related to the subgrid clouds. From now on, all minor commits are captured in the public-facing submodule repository and the submodule will be updated in WRF at a lower frequency (probably every 6 months or so).

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)
M .gitmodules
M Makefile
M Registry/Registry.EM_COMMON
M clean
M dyn_em/module_first_rk_step_part1.F
M main/depend.common
A phys/MYNN-EDMF
M phys/Makefile
D phys/module_bl_mynn.F
D phys/module_bl_mynn_common.F
D phys/module_bl_mynn_wrapper.F
M phys/module_pbl_driver.F
M phys/module_physics_init.F

TESTS CONDUCTED:

The submodule itself has been tested in both WRF and MPAS for several months now in NOAA-GSL realtime systems and case study tests, passing all of our newly designed regression tests.
Has been compiled and run with intel and gnu compilers on Jet and Hera.
Are the Jenkins tests all passing?

RELEASE NOTE: Submodule implementation of the MYNN-EDMF (https://github.com/NCAR/MYNN-EDMF). The module names changed from mynn to mynnedmf to resolve a version conflict in MPAS. This version was originally developed within FV3/CCPP for RRFSv1, but has been refactored (to a k-only scheme) resulting in a speed-up of about 10-15% and it has since been tuned to better perform in MPAS and WRF compared to previous versions which were primarily developed for use in FV3.

…ray.

joeolson42 · 2025-01-01T12:03:33Z

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

joeolson42 · 2025-01-04T02:44:54Z

Results after the latest update:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

dudhia

Fine from rest-of-physics perspective

weiwangncar · 2025-01-13T07:05:57Z

phys/Makefile

+	@if [ \( ! -f module_bl_mynnedmf.F \) -o \( ! -f module_bl_mynedmf_common.F \) -o \
+	      \( ! -f module_bl_mynnedmf_driver.F \) ] ; then \
+	      	echo Pulling in MYNN-EDMF submodule ; \
+		( cd .. ; git submodule update --init --recursive ) ; \


Does this always get the latest modules/files from the MYNN repository?

joeolson42 · 2025-01-13T22:36:37Z

No. When you do the "git add MYNN-EDMF" from the physics directory, it ties WRF to that specific hash of the MYNN-EDMF. I would have to make another PR to update the specific version of the MYNN-EDMF that is automatically cloned when cloning WRF. That said, anyone can go into the MYNN-EDMF directory and do a "git pull" to get the latest if they so desire.

…

-joe

On Mon, Jan 13, 2025 at 1:06 AM weiwangncar ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In phys/Makefile <#2148 (comment)>: > @@ -270,7 +270,17 @@ submodules : else \ echo No action required for NoahMP submodule ; \ fi - + @if [ \( ! -f module_bl_mynnedmf.F \) -o \( ! -f module_bl_mynedmf_common.F \) -o \ + \( ! -f module_bl_mynnedmf_driver.F \) ] ; then \ + echo Pulling in MYNN-EDMF submodule ; \ + ( cd .. ; git submodule update --init --recursive ) ; \ Does this always get the latest modules/files from the MYNN repository? — Reply to this email directly, view it on GitHub <#2148 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLRR3SBCHU773OXZWHEM2D2KNQWXAVCNFSM6AAAAABUN5MS3KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBVHA2TOMBZGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Joseph Olson Numerical Weather Prediction Model Developer Environmental Prediction Advancement Division NOAA-Global Systems Laboratory Boulder, Colorado

dudhia · 2025-01-13T22:52:04Z

OK. That's the behavior we want. We want the hash to stay fixed for a release.

islas

Is there any specific reason we want to continue using git submodules for new changes, as opposed to manage_externals?

Also this needs to be updated for the CMake build as well.

dudhia · 2025-01-14T19:23:36Z

In this case the developer found it easier to follow the existing NoahMP example as we didn't have manage_externals in the last release.

…

On Tue, Jan 14, 2025 at 12:05 PM Anthony Islas ***@***.***> wrote: ***@***.**** requested changes on this pull request. Is there any specific reason we want to continue using git submodules for new changes, as opposed to manage_externals? Also this needs to be updated for the CMake build as well. — Reply to this email directly, view it on GitHub <#2148 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77HDP3HE4OAJNZ7UMRL2KVNW3AVCNFSM6AAAAABUN5MS3KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJQG44TCMJVGQ> . You are receiving this because your review was requested.Message ID: ***@***.***>

islas · 2025-01-14T20:10:00Z

@dudhia I understand, however as we now have manage_externals in place within the develop branch, if we plan on managing submodules that way we have the opportunity to implement these changes with manage_externals right now while this is still in review. Deferring this adds technical debt that must be address by someone at some future time.

If our plans are not to move things under manage_externals, then that's fine but it does beg the question why manage_externals was introduced in the first place...

dudhia · 2025-01-14T22:06:10Z

Not knowing what it entails myself, what would such a change look like from the point of view of the developer with his own repository and the way they do updates. I also want to see if the CCPP people have a preferred way of doing this.

…

On Tue, Jan 14, 2025 at 1:10 PM Anthony Islas ***@***.***> wrote: @dudhia <https://github.com/dudhia> I understand, however as we now have manage_externals in place within the develop branch, if we plan on managing submodules that way we have the opportunity to implement these changes with manage_externals right now while this is still in review. Deferring this adds technical debt that must be address by *someone* at some future time. If our plans are not to move things under manage_externals, then that's fine but it does beg the question why manage_externals was introduced in the first place... — Reply to this email directly, view it on GitHub <#2148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77ERM5IXC7QUK4ILYSD2KVVK7AVCNFSM6AAAAABUN5MS3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJRGAYTANBQHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

weiwangncar · 2025-01-15T01:09:48Z

My understanding is that whether using manage externals or submodule does not have impact on how the source code repositories are maintained. It is the choice of the host model.
Since Joe is not familiar with the use of manage externals, one way to work with this is to merge this PR first, and I can make the change to use manage externals after that.

dudhia · 2025-01-15T16:04:08Z

I agree with that. So far my thinking was that only shared physics had to be manage externals.

…

On Tue, Jan 14, 2025 at 6:10 PM weiwangncar ***@***.***> wrote: My understanding is that whether using manage externals or submodule does not have impact on how the source code repositories are maintained. It is the choice of the host model. Since Joe is not familiar with the use of manage externals, one way to work with this is to merge this PR first, and I can make the change to use manage externals after that. — Reply to this email directly, view it on GitHub <#2148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77GUBU64EQXHMMGUCND2KWYPDAVCNFSM6AAAAABUN5MS3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJRGQZDINRUGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

joeolson42 · 2025-01-15T19:58:36Z

I'm fine with whatever you want to do. At the moment, I don't know anything about manage_externals. I'm only familiar with the standard git method, which is the same way CCPP handles all submodules.

…

On Wed, Jan 15, 2025 at 10:04 AM dudhia ***@***.***> wrote: I agree with that. So far my thinking was that only shared physics had to be manage externals. On Tue, Jan 14, 2025 at 6:10 PM weiwangncar ***@***.***> wrote: > My understanding is that whether using manage externals or submodule does > not have impact on how the source code repositories are maintained. It is > the choice of the host model. > Since Joe is not familiar with the use of manage externals, one way to > work with this is to merge this PR first, and I can make the change to use > manage externals after that. > > — > Reply to this email directly, view it on GitHub > <#2148 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AEIZ77GUBU64EQXHMMGUCND2KWYPDAVCNFSM6AAAAABUN5MS3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJRGQZDINRUGI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#2148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLRR3UXXQM6UGRCFXLOGXD2K2BJBAVCNFSM6AAAAABUN5MS3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTGMZDQOJWHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Joseph Olson Numerical Weather Prediction Model Developer Environmental Prediction Advancement Division NOAA-Global Systems Laboratory Boulder, Colorado

dudhia · 2025-01-16T17:03:24Z

@islas we can defer thinking about manage externals to later. Does this commit break with cmake?

islas · 2025-01-16T19:53:12Z

@dudhia I'm fine with deferring the submodule/manage externals resolution on this PR, but I'd like for it to be a priority overall for the v4.7 release

@joeolson42 I can make the appropriate CMake changes necessary if you'd like. Otherwise, if you want to do that instead, it should only be a matter of adding the file paths to the phys/CMakeLists.txt

dudhia · 2025-01-22T16:56:11Z

@islas maybe you have to remove changes requested to allow us to merge this for now?

islas · 2025-01-23T00:59:36Z

@dudhia @weiwangncar I've added the new MYNN-EDMF files to the appropriate location within the CMake files

weiwangncar · 2025-01-28T07:48:20Z

@islas Would it be ok if we merge this PR now and we will make a change afterwards to use manage_externals?

Subset of requested changes to be addressed later

islas · 2025-01-29T02:15:18Z

@weiwangncar Apologies for the hold up. I thought re-requesting my review (self-requested) dismissed my request for changes.

@cenlinhe

# WRF Version v4.7.0 The WRF model has been update to Version v4.7.0 on April 25, 2025 __Acknowledgements__: We would like to thank * Adam Dury (WeatherQuest) * Andrea Zonato, Royal Netherlands Meteorological Institute (KNMI) * Benjamin Kirk & Negin Sobhani (NSF NCAR / CISL) * Cenlin He @cenlinhe and Tzu-Shun Lin (NCAR) * Charlie Li, software developer from lakes environmental, Canada * Jakub Lewandowski (University of Leeds) * James Ruppert (University of Oklahoma) * Joseph Olson (NOAA/GSL) * Alexander Ukhov (KAUST) * L. Fita (UBA/CIMA/IFAECI) * Lukas Pilz (Heidelberg University) * Martilli, Alberto (CIEMAT) * Mathieu Landreau (Centrale Nantes) * Robert Conrick (U. of Washington); [email protected] * Robert Gilliam & Jon Pleim, US EPA * Sergey Osipov (KAUST) * Tanya Spero (U.S. EPA) * Ted Mansell (NOAA/NSSL) (@MicroTed ) for their contributions to this release. ## Physics * Fix an error associated with using LCZ categories in NoahMP. Prior to this fix, the LCZs were not correctly referenced, hence ignored in the NoahMP code. (#2202) [Details](a176a5965) * NSSL-mp bug fix for (obsolete) droplet nucleation (#2195) [Details](30c03dc40) * NSSL microphysics scheme updates include 1. An explicit rain breakup for 3-moment rain (addresses issue of cold pools being too warm and drops being too large in rain cores), 2. Improved reflectivity conservation for graupel->hail conversion and drop freezing, 3. More accurate saturation mixing ratio calculation, 4. New default droplet nucleation that controls excess supersaturation much better than previously (and default is to always predict the number of activated CCN). The update has been submitted to CCPP repository as well. (#2170) [Details](9d763af90) * An new microphysics, UFS Double Moment (UDM), 7-class microphysics from Songyou Hong is added (mp_physics=27). UDM mp largely adopts microphysical processes in WDM7, but with bug fixes or revisions based on literature and accumulated realism. UDM mp utilizes the in-cloud microphysics concept (Kim and Hong 2018), with the addition of water-friendly aerosols for CCN initialization. Semi-lagrangian sedimentation of Juang and Hong (2010) is also re-configured for computational efficiency and numerical accuracy. All production terms are optimized by introducing a cloud-top definition for hydrometeors. (#2147) [Details](5fc76c540) * Release of the RCON Microphysics package into WRF, which improves upon the warm rain representation of the Thompson-Eidhammer scheme. RCON is based heavily on the Thompson-Eidhammer scheme with a couple significant changes that improve upon the code in module_mp_rcon.F to generate more realistic rainfall during warm rain events with additional benefits for cold rain, especially warm processes during cold rain events. Among the most significant changes for rain productions are 1) the use of a wider cloud water DSD of lognormal shape instead of the gamma DSD used by the Thompson-Eidhammer parameterization and 2) enhancement of the cloud-to-rain autoconversion parameterization to accommodate the new shape. The changes here also allow for sedimentation of cloud water within the lowest model layer, which effectively creates a drizzle mode in the scheme. Accompanying published reference: Conrick, R., C. F. Mass, and L. McMurdie, 2023: Improving Simulations of Warm Rain in a Bulk Microphysics Scheme. Mon. Wea. Rev., 152, 169-185, https://doi.org/10.1175/MWR-D-23-0035.1. (#2144) [Details](de213c920) * Fix an erroneous print for using ghg_input when no radiation option is selected, mostly from idealized cases. (#2199) [Details](bd4ecbe01) * Fix a loop index error in bep_bem urban code. (#2196) [Details](0171299d3) * Noah-MP bug fixes for (1) allowing BATS snow albedo scheme for nighttime snow aging, (2) the potential leakage caused by calculate_soil variable during parallelized run, (3) the missing of HCPCT output for glacier points. (#2160) [Details](fd079bf48) * The similarity stability functions phim and phieps, necessary for calculating the surface values of tke and dissipation rate in the tke-epsilon-tpe PBL scheme [Zonato et al., 2022](https://doi.org/10.1175/MWR-D-21-0299.1) have been updated considering the correction term accounting for the roughness length z0. No relevant differences are found in temperature, wind speed, and humidity. Regarding turbulence variables, the stable case has just negligible differences, while the unstable case shows higher values of TKE and dissipation rate and lower values of temperature variance. (#2120) [Details](70855a73e) * Pleim-Xiu LSM is now compatible with 61 category MODIS LCZ landuse dataset. A mode of latent heat effects on Tg from vegetated parts and from wet leaves is added to Pleim-Xiu LSM. (#2023) [Details](b7f31dcde) ## Software * Determine MPI Data Types in col_on_comm() & dst_on_comm() to prevent displacements overflow. (#2157) [Details](af8101493) * CMake README documentation on <PackageName>_ROOT variables (#2190) [Details](33036d613) * CMake README documentation typo fixes (#2189) [Details](3fd1aefda) * Fix aarch64 GCC build when DM configuration selected (#2192) [Details](8e1d6742c) * Fixed failed compilation with Intel oneAPI by reworking the dependency linking of hydro CMake compilation (#2178) [Details](2e0694f14) * Fix compilation of grib2 IO in make build (#2191) [Details](2639dcd3f) * Fix uncontrollable building of external/io_netcdfpar folder for all stanzas (#2181) [Details](127a8f40a) * Suppress MYNN-EDMF verify checkout command (#2188) [Details](3f2465b41) * Fix typo in confcheck CMakeLists.txt for FSEEKO (#2179) [Details](2572bc5f5) * Add quotes to optimization flags exceptions in CMake (#2180) [Details](b15e341e4) * CMake Chem and Chem+KPP Build (#2018) [Details](b26e64595) * Consistent double precision definitions (#2099) [Details](704259871) * CMake Fix split command flags to be correctly populated (#2108) [Details](5b09725f5) * CMake WRFPLUS (#2089) [Details](695f455e8) * Override CMake-injected optimization flags in favor of the flags set by the build system and provided stanza information. (#2138) [Details](b6542b0f7) * Fixed CMake dev warning `project() should be called prior to this enable_language() call` appearing when using `configure_new` script with some newer versions of Cmake. (#2125) [Details](0ccba14eb) * Add documentation to custom properties in CMake to fix compatibility with older versions. (#2131) [Details](f204246a0) * Remove leading -D on defines during stanza reading to allow older versions of CMake to configure properly. (#2130) [Details](c2e121f56) * Bug fix in CMake FindnetCDF.cmake for empty --has-* nc-config fields (#2135) [Details](f096921b2) * CMake confcheck switch to try_* functions (#2090) [Details](5dd2c192d) * Bug fix in landread.c to address undefined behavior by adding an explicit return statement in `GET_LANDUSE()` function (#2197) [Details](5ef63ba34) * Fix memory leaks related to arrays being allocated without being deallocated in start_em and time series calculation subroutines. (#2139) [Details](94aa27a7e) * Fix an access violation error when a PGI compiler is used with urban variables in module_bl_ysu.F when urban option is turned off and the memories of those arrays are not available. (#2137) [Details](33ce70c0f) * Updated grav_settling code to better recognize the land use type so it doesn't crash. Also update the error message if it does crash to go into the rsl.error files rather than rsl.out files. (#2110) [Details](b3eebb3fe) * Bug fix for wrfinput where LCZ urban cells in LU_INDEX were overwritten with default USGS urban category. (#2153) [Details](d96478d4f) * Add manage_externals tool to access physics modules in MMM-physics git repository. (#2126) [Details](7195dc250) * Submodule implementation of the MYNN-EDMF (https://github.com/NCAR/MYNN-EDMF). The module names changed from *_mynn_* to *_mynnedmf_* to resolve a version conflict in MPAS. This version was originally developed within FV3/CCPP for RRFSv1, but has been refactored (to a k-only scheme) resulting in a speed-up of about 10-15% and it has since been tuned to better perform in MPAS and WRF compared to previous versions which were primarily developed for use in FV3. (#2148) [Details](383476531) * When the namelist option write_hist_at_0h_rst is set to .true. under &time_control, history write-out will now be conducted for the first time step for both the 0th stream (wrfout* files) and any special user-defined streams being implemented. (#2133) [Details](61d1c84cb) ## Dynamics * Corrected algorithms in the tipping bucket for precipitation and in the nudging routines to adjust for imprecision in single-precision real numbers exceeding the resolvable values in long (>23-year) continuous simulations. (#2063) [Details](a32188308) ## Data Assimilation * This PR adds an incremental analysis update capability. In the DA code, code is added to write out analysis increments for all variables in WRF netCDF format using auxiliary history output stream #5. In the model, analysis increments are divided by the number of time steps in a specified time window and added to the model similar to physics tendencies. The input stream for the model is 15. The capability is turned on by adding iau = 1 and iau_time_window_sec in &time_control. The way the increments are added to the model is similar to what described by the paper by Chen et al. (https://doi-org.cuucar.idm.oclc.org/10.1175/WAF-D-22-0127.1). (#2151) [Details](6741f010e) ## Chemistry * Bug fix in the calculation of optical properties. Mass redistribution between GOCART dust/sea salt and MOZAIC bins was corrected. It slightly increased (by 3-5%) the aerosol optical depth (AOD). (#2112) [Details](bb791e73d) * Fix a bug where TUV and FTUV fail to initialize the distance to the Sun properly if the simulation starts on 1 Jan. (#2171) [Details](9aa3979f0) ## Hydro * In `hydro.namelist` adding lake_opt to namelist, reservoirs to own namelist. Support for lakes (reservoirs) in non-UDMP reach-based routing added and some style guide cleanup completed. (#2146) [Details](6d1db68f6) * Hydro reservoir drainage area (DA) lake option bugfix (#2182) [Details](313834d41) ## Miscellaneous * Update README.namelist file (#2193) [Details](7053a6ae9) * A namelist option, default_soiltype, is added to define filled-in land category along water/land boundaries where soil data may be missing in program real. (#2166) [Details](2f68d7b70) * Add dzstretch_u and dzbot in namelist.input. Users are advised to check UG for other parameters to use. (#2165) [Details](89ba5181b) * Noah-MP code tag is updated to corresponding to WRFV4.7 release. (#2207) [Details](f11e38164) * Fixed defs for adap time step namelist vars in README.namelist (#2158) [Details](30a16a1ce)

@cenlinhe

# WRF Version v4.7.0 The WRF model has been update to Version v4.7.0 on April 25, 2025 __Acknowledgements__: We would like to thank * Adam Dury (WeatherQuest) * Andrea Zonato, Royal Netherlands Meteorological Institute (KNMI) * Benjamin Kirk & Negin Sobhani (NSF NCAR / CISL) * Cenlin He @cenlinhe and Tzu-Shun Lin (NCAR) * Charlie Li, software developer from lakes environmental, Canada * Jakub Lewandowski (University of Leeds) * James Ruppert (University of Oklahoma) * Joseph Olson (NOAA/GSL) * Alexander Ukhov (KAUST) * L. Fita (UBA/CIMA/IFAECI) * Lukas Pilz (Heidelberg University) * Martilli, Alberto (CIEMAT) * Mathieu Landreau (Centrale Nantes) * Robert Conrick (U. of Washington); [email protected] * Robert Gilliam & Jon Pleim, US EPA * Sergey Osipov (KAUST) * Tanya Spero (U.S. EPA) * Ted Mansell (NOAA/NSSL) (@MicroTed ) for their contributions to this release. ## Physics * Fix an error associated with using LCZ categories in NoahMP. Prior to this fix, the LCZs were not correctly referenced, hence ignored in the NoahMP code. (#2202) [Details](a176a5965) * NSSL-mp bug fix for (obsolete) droplet nucleation (#2195) [Details](30c03dc40) * NSSL microphysics scheme updates include 1. An explicit rain breakup for 3-moment rain (addresses issue of cold pools being too warm and drops being too large in rain cores), 2. Improved reflectivity conservation for graupel->hail conversion and drop freezing, 3. More accurate saturation mixing ratio calculation, 4. New default droplet nucleation that controls excess supersaturation much better than previously (and default is to always predict the number of activated CCN). The update has been submitted to CCPP repository as well. (#2170) [Details](9d763af90) * An new microphysics, UFS Double Moment (UDM), 7-class microphysics from Songyou Hong is added (mp_physics=27). UDM mp largely adopts microphysical processes in WDM7, but with bug fixes or revisions based on literature and accumulated realism. UDM mp utilizes the in-cloud microphysics concept (Kim and Hong 2018), with the addition of water-friendly aerosols for CCN initialization. Semi-lagrangian sedimentation of Juang and Hong (2010) is also re-configured for computational efficiency and numerical accuracy. All production terms are optimized by introducing a cloud-top definition for hydrometeors. (#2147) [Details](5fc76c540) * Release of the RCON Microphysics package into WRF, which improves upon the warm rain representation of the Thompson-Eidhammer scheme. RCON is based heavily on the Thompson-Eidhammer scheme with a couple significant changes that improve upon the code in module_mp_rcon.F to generate more realistic rainfall during warm rain events with additional benefits for cold rain, especially warm processes during cold rain events. Among the most significant changes for rain productions are 1) the use of a wider cloud water DSD of lognormal shape instead of the gamma DSD used by the Thompson-Eidhammer parameterization and 2) enhancement of the cloud-to-rain autoconversion parameterization to accommodate the new shape. The changes here also allow for sedimentation of cloud water within the lowest model layer, which effectively creates a drizzle mode in the scheme. Accompanying published reference: Conrick, R., C. F. Mass, and L. McMurdie, 2023: Improving Simulations of Warm Rain in a Bulk Microphysics Scheme. Mon. Wea. Rev., 152, 169-185, https://doi.org/10.1175/MWR-D-23-0035.1. (#2144) [Details](de213c920) * Fix an erroneous print for using ghg_input when no radiation option is selected, mostly from idealized cases. (#2199) [Details](bd4ecbe01) * Fix a loop index error in bep_bem urban code. (#2196) [Details](0171299d3) * Noah-MP bug fixes for (1) allowing BATS snow albedo scheme for nighttime snow aging, (2) the potential leakage caused by calculate_soil variable during parallelized run, (3) the missing of HCPCT output for glacier points. (#2160) [Details](fd079bf48) * The similarity stability functions phim and phieps, necessary for calculating the surface values of tke and dissipation rate in the tke-epsilon-tpe PBL scheme [Zonato et al., 2022](https://doi.org/10.1175/MWR-D-21-0299.1) have been updated considering the correction term accounting for the roughness length z0. No relevant differences are found in temperature, wind speed, and humidity. Regarding turbulence variables, the stable case has just negligible differences, while the unstable case shows higher values of TKE and dissipation rate and lower values of temperature variance. (#2120) [Details](70855a73e) * Pleim-Xiu LSM is now compatible with 61 category MODIS LCZ landuse dataset. A mode of latent heat effects on Tg from vegetated parts and from wet leaves is added to Pleim-Xiu LSM. (#2023) [Details](b7f31dcde) ## Software * Determine MPI Data Types in col_on_comm() & dst_on_comm() to prevent displacements overflow. (#2157) [Details](af8101493) * CMake README documentation on <PackageName>_ROOT variables (#2190) [Details](33036d613) * CMake README documentation typo fixes (#2189) [Details](3fd1aefda) * Fix aarch64 GCC build when DM configuration selected (#2192) [Details](8e1d6742c) * Fixed failed compilation with Intel oneAPI by reworking the dependency linking of hydro CMake compilation (#2178) [Details](2e0694f14) * Fix compilation of grib2 IO in make build (#2191) [Details](2639dcd3f) * Fix uncontrollable building of external/io_netcdfpar folder for all stanzas (#2181) [Details](127a8f40a) * Suppress MYNN-EDMF verify checkout command (#2188) [Details](3f2465b41) * Fix typo in confcheck CMakeLists.txt for FSEEKO (#2179) [Details](2572bc5f5) * Add quotes to optimization flags exceptions in CMake (#2180) [Details](b15e341e4) * CMake Chem and Chem+KPP Build (#2018) [Details](b26e64595) * Consistent double precision definitions (#2099) [Details](704259871) * CMake Fix split command flags to be correctly populated (#2108) [Details](5b09725f5) * CMake WRFPLUS (#2089) [Details](695f455e8) * Override CMake-injected optimization flags in favor of the flags set by the build system and provided stanza information. (#2138) [Details](b6542b0f7) * Fixed CMake dev warning `project() should be called prior to this enable_language() call` appearing when using `configure_new` script with some newer versions of Cmake. (#2125) [Details](0ccba14eb) * Add documentation to custom properties in CMake to fix compatibility with older versions. (#2131) [Details](f204246a0) * Remove leading -D on defines during stanza reading to allow older versions of CMake to configure properly. (#2130) [Details](c2e121f56) * Bug fix in CMake FindnetCDF.cmake for empty --has-* nc-config fields (#2135) [Details](f096921b2) * CMake confcheck switch to try_* functions (#2090) [Details](5dd2c192d) * Bug fix in landread.c to address undefined behavior by adding an explicit return statement in `GET_LANDUSE()` function (#2197) [Details](5ef63ba34) * Fix memory leaks related to arrays being allocated without being deallocated in start_em and time series calculation subroutines. (#2139) [Details](94aa27a7e) * Fix an access violation error when a PGI compiler is used with urban variables in module_bl_ysu.F when urban option is turned off and the memories of those arrays are not available. (#2137) [Details](33ce70c0f) * Updated grav_settling code to better recognize the land use type so it doesn't crash. Also update the error message if it does crash to go into the rsl.error files rather than rsl.out files. (#2110) [Details](b3eebb3fe) * Bug fix for wrfinput where LCZ urban cells in LU_INDEX were overwritten with default USGS urban category. (#2153) [Details](d96478d4f) * Add manage_externals tool to access physics modules in MMM-physics git repository. (#2126) [Details](7195dc250) * Submodule implementation of the MYNN-EDMF (https://github.com/NCAR/MYNN-EDMF). The module names changed from *_mynn_* to *_mynnedmf_* to resolve a version conflict in MPAS. This version was originally developed within FV3/CCPP for RRFSv1, but has been refactored (to a k-only scheme) resulting in a speed-up of about 10-15% and it has since been tuned to better perform in MPAS and WRF compared to previous versions which were primarily developed for use in FV3. (#2148) [Details](383476531) * When the namelist option write_hist_at_0h_rst is set to .true. under &time_control, history write-out will now be conducted for the first time step for both the 0th stream (wrfout* files) and any special user-defined streams being implemented. (#2133) [Details](61d1c84cb) ## Dynamics * Corrected algorithms in the tipping bucket for precipitation and in the nudging routines to adjust for imprecision in single-precision real numbers exceeding the resolvable values in long (>23-year) continuous simulations. (#2063) [Details](a32188308) ## Data Assimilation * This PR adds an incremental analysis update capability. In the DA code, code is added to write out analysis increments for all variables in WRF netCDF format using auxiliary history output stream #5. In the model, analysis increments are divided by the number of time steps in a specified time window and added to the model similar to physics tendencies. The input stream for the model is 15. The capability is turned on by adding iau = 1 and iau_time_window_sec in &time_control. The way the increments are added to the model is similar to what described by the paper by Chen et al. (https://doi-org.cuucar.idm.oclc.org/10.1175/WAF-D-22-0127.1). (#2151) [Details](6741f010e) ## Chemistry * Bug fix in the calculation of optical properties. Mass redistribution between GOCART dust/sea salt and MOZAIC bins was corrected. It slightly increased (by 3-5%) the aerosol optical depth (AOD). (#2112) [Details](bb791e73d) * Fix a bug where TUV and FTUV fail to initialize the distance to the Sun properly if the simulation starts on 1 Jan. (#2171) [Details](9aa3979f0) ## Hydro * In `hydro.namelist` adding lake_opt to namelist, reservoirs to own namelist. Support for lakes (reservoirs) in non-UDMP reach-based routing added and some style guide cleanup completed. (#2146) [Details](6d1db68f6) * Hydro reservoir drainage area (DA) lake option bugfix (#2182) [Details](313834d41) ## Miscellaneous * Update README.namelist file (#2193) [Details](7053a6ae9) * A namelist option, default_soiltype, is added to define filled-in land category along water/land boundaries where soil data may be missing in program real. (#2166) [Details](2f68d7b70) * Add dzstretch_u and dzbot in namelist.input. Users are advised to check UG for other parameters to use. (#2165) [Details](89ba5181b) * Noah-MP code tag is updated to corresponding to WRFV4.7 release. (#2207) [Details](f11e38164) * Fixed defs for adap time step namelist vars in README.namelist (#2158) [Details](30a16a1ce)

joeolson42 added 3 commits December 31, 2024 19:10

Switching MYNN to MYNN-EDMF submodule

4a66da2

switching spaces to tabs

54b6fa7

remove ktop_plume--no longer a MYNN-EDMF variable

55c1fa4

joeolson42 requested review from a team as code owners December 31, 2024 21:16

Updating MYNN-EDMF submodule to correct an index problem in a chem ar…

9a0db6f

…ray.

weiwangncar added the Develop Branch label Jan 1, 2025

Updating MYNN-EDMF submodule to impose bounds on qnwfa and qnifa

75f1031

dudhia approved these changes Jan 9, 2025

View reviewed changes

weiwangncar reviewed Jan 13, 2025

View reviewed changes

weiwangncar previously approved these changes Jan 14, 2025

View reviewed changes

dudhia previously approved these changes Jan 14, 2025

View reviewed changes

islas previously requested changes Jan 14, 2025

View reviewed changes

Add MYNN-EDMF files to phys/CMakeLists.txt

23ac016

islas dismissed stale reviews from dudhia and weiwangncar via 23ac016 January 23, 2025 00:56

islas self-requested a review January 23, 2025 00:58

weiwangncar approved these changes Jan 23, 2025

View reviewed changes

dudhia approved these changes Jan 28, 2025

View reviewed changes

islas merged commit 3834765 into wrf-model:develop Jan 29, 2025
1 check was pending

Implementation of MYNN-EDMF submodule #2148

Implementation of MYNN-EDMF submodule #2148

Uh oh!

Conversation

joeolson42 commented Dec 31, 2024

Uh oh!

joeolson42 commented Jan 1, 2025

Uh oh!

joeolson42 commented Jan 4, 2025

Uh oh!

dudhia left a comment

Choose a reason for hiding this comment

Uh oh!

weiwangncar Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

joeolson42 commented Jan 13, 2025 via email

Uh oh!

dudhia commented Jan 13, 2025

Uh oh!

islas left a comment

Choose a reason for hiding this comment

Uh oh!

dudhia commented Jan 14, 2025 via email

Uh oh!

islas commented Jan 14, 2025

Uh oh!

dudhia commented Jan 14, 2025 via email

Uh oh!

weiwangncar commented Jan 15, 2025

Uh oh!

dudhia commented Jan 15, 2025 via email

Uh oh!

joeolson42 commented Jan 15, 2025 via email

Uh oh!

dudhia commented Jan 16, 2025

Uh oh!

islas commented Jan 16, 2025

Uh oh!

dudhia commented Jan 22, 2025

Uh oh!

islas commented Jan 23, 2025

Uh oh!

weiwangncar commented Jan 28, 2025

Uh oh!

islas commented Jan 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants