Skip to content

Update GFL to its latest with bug fixes#2314

Merged
weiwangncar merged 1 commit intowrf-model:release-v4.8.0from
weiwangncar:update-gfl
Apr 13, 2026
Merged

Update GFL to its latest with bug fixes#2314
weiwangncar merged 1 commit intowrf-model:release-v4.8.0from
weiwangncar:update-gfl

Conversation

@weiwangncar
Copy link
Copy Markdown
Collaborator

@weiwangncar weiwangncar commented Apr 13, 2026

TYPE: bug fix

KEYWORDS: GFL, seg fault

SOURCE: Haiqin Li and internal

DESCRIPTION OF CHANGES:
Three dimensional Qc and Qi were not passed to the GFL scheme where they are used to compute cloud fraction by the CPS. This PR points to an updated GFL where cloud fraction as well as reflectivity due to the CPS are disabled for now in WRF.

LIST OF MODIFIED FILES:
Only update the pointer to the GFL repository

TESTS CONDUCTED:

  1. Tests are run on NOAA HPC and Derecho and seg fault problem is resolved.
  2. The Jenkins tests all passing.

RELEASE NOTE:

@weiwangncar weiwangncar requested a review from a team as a code owner April 13, 2026 16:28
@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Apr 13, 2026

It comments out a cloud frcation calculation?

@weiwangncar
Copy link
Copy Markdown
Collaborator Author

@dudhia Yes. Because it requires 3D Qc and Qi which Haiqin didn't pass in to the scheme. He could choose to add those arrays, but it will also mean it needs to make sure the radiation will take it. I guess he just chose not to do it.

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Apr 13, 2026

So that cloud fraction is disabled?

@weiwangncar
Copy link
Copy Markdown
Collaborator Author

@dudhia I'm not sure how they do it now. @haiqinli ?

@weiwangncar
Copy link
Copy Markdown
Collaborator Author

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@haiqinli
Copy link
Copy Markdown

haiqinli commented Apr 13, 2026

So that cloud fraction is disabled?

Yes, we don't have convective clouds & radiation coupling in WRF. We can do it later with some tunings.

@weiwangncar weiwangncar merged commit 2cf2665 into wrf-model:release-v4.8.0 Apr 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants