Update GFL to its latest with bug fixes#2314
Merged
weiwangncar merged 1 commit intowrf-model:release-v4.8.0from Apr 13, 2026
Merged
Update GFL to its latest with bug fixes#2314weiwangncar merged 1 commit intowrf-model:release-v4.8.0from
weiwangncar merged 1 commit intowrf-model:release-v4.8.0from
Conversation
Collaborator
|
It comments out a cloud frcation calculation? |
Collaborator
Author
|
@dudhia Yes. Because it requires 3D Qc and Qi which Haiqin didn't pass in to the scheme. He could choose to add those arrays, but it will also mean it needs to make sure the radiation will take it. I guess he just chose not to do it. |
Collaborator
|
So that cloud fraction is disabled? |
Collaborator
Author
Collaborator
Author
|
The regression test results: |
Yes, we don't have convective clouds & radiation coupling in WRF. We can do it later with some tunings. |
dudhia
approved these changes
Apr 13, 2026
islas
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: GFL, seg fault
SOURCE: Haiqin Li and internal
DESCRIPTION OF CHANGES:
Three dimensional Qc and Qi were not passed to the GFL scheme where they are used to compute cloud fraction by the CPS. This PR points to an updated GFL where cloud fraction as well as reflectivity due to the CPS are disabled for now in WRF.
LIST OF MODIFIED FILES:
Only update the pointer to the GFL repository
TESTS CONDUCTED:
RELEASE NOTE: