Skip to content

Adding MPI parallelization to CFBM#2315

Merged
islas merged 13 commits intowrf-model:release-v4.8.0from
pedro-jm:cfbm_mpi
May 5, 2026
Merged

Adding MPI parallelization to CFBM#2315
islas merged 13 commits intowrf-model:release-v4.8.0from
pedro-jm:cfbm_mpi

Conversation

@pedro-jm
Copy link
Copy Markdown
Contributor

@pedro-jm pedro-jm commented Apr 16, 2026

TYPE: bug fix

KEYWORDS: MPI parallelization with CFBM

SOURCE: Pedro Jimenez (NCAR/RAL)

DESCRIPTION OF CHANGES:
Problem:
MPI parallelization with CFBM only run with 1 MPI task.
It also adds the bilinear interpolation of atmospheric variables in the fire grid.

Solution:
We have allowed for parallelization using multiple MPI tasks.

ISSUE: N/A

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
A doc/README.cfbm
M dyn_em/module_first_rk_step_part1.F
M dyn_em/start_em.F
M phys/fire_behavior
M share/module_check_a_mundo.F

TESTS CONDUCTED:

  1. We run test with 1, 2, and 3 MPI tasks and we get bit for bit results

  2. Are the Jenkins tests all passing? Yes
    Test Type | Expected | Received | Failed
    = = = = = = = = = = = = = = = = = = = = = = = = = = = =
    Number of Tests : 23 24
    Number of Builds : 60 57
    Number of Simulations : 158 150 0
    Number of Comparisons : 95 86 0

    Failed Simulations are:
    None
    Which comparisons are not bit-for-bit:
    None

RELEASE NOTE: Allowing for multiple MPI tasks when running the Community Fire Behavior model

@pedro-jm pedro-jm requested a review from a team as a code owner April 16, 2026 00:54
@pedro-jm pedro-jm requested a review from a team as a code owner April 16, 2026 13:48
@islas
Copy link
Copy Markdown
Collaborator

islas commented Apr 20, 2026

@pedro-jm I think it may be worth adding a doc/README.cfbm, even if simple. That way we can capture that right now it is limited to one domain, and any other caveats that should be noted.

Otherwise, this looks fairly clean!

@pedro-jm
Copy link
Copy Markdown
Contributor Author

@islas I just pushed the README.cfbm. I also mentioned one needs to compile with cmake and put some info on how to do it.

Comment thread dyn_em/module_first_rk_step_part1.F
@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Apr 23, 2026

Not sure why this regtest has not completed yet.

@weiwangncar
Copy link
Copy Markdown
Collaborator

@dudhia Changing text files do not start a reg test. The last successful regtest is from commit f1dcff7.

The regression results for this commit is pass.

@weiwangncar
Copy link
Copy Markdown
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Comment thread dyn_em/module_first_rk_step_part1.F
@islas islas merged commit 9edeb07 into wrf-model:release-v4.8.0 May 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants