Repository navigation
Decouple hook capture from synchronous observe - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/agentmemory/observe/async, which returns202after dispatchingmem::observewith iii fire-and-forget ownership./agentmemory/observesynchronous and backward-compatible for API clients such as the demo and OpenCode integration.Root cause and impact
Hook processes force-exit after 500 ms, but the synchronous observe endpoint waits for persistence, indexing, session updates, and stream fanout. When that work crosses the hook lifetime, the HTTP caller disappears while iii still tracks downstream invocation state. The async boundary acknowledges accepted hook work promptly and lets the engine own its completion.
Validation
npm test(133 files, 1,439 tests passed)npx vitest run test/api-observe-async.test.ts test/copilot-plugin.test.ts test/consistency.test.ts test/fs-watcher.test.ts(41 passed)npm run skills:check(15 skills passed)npm run buildgit diff --check