Skip to content

Comments

feat: Add comprehensive security coding expert agents with improved descriptions#62

Merged
wshobson merged 4 commits intowshobson:mainfrom
ChanMeng666:main
Sep 15, 2025
Merged

feat: Add comprehensive security coding expert agents with improved descriptions#62
wshobson merged 4 commits intowshobson:mainfrom
ChanMeng666:main

Conversation

@ChanMeng666
Copy link
Contributor

@ChanMeng666 ChanMeng666 commented Sep 9, 2025

This PR adds three new security-focused coding expert agents with shortened descriptions and improved clarity:

New Agents Added

  • backend-security-coder.md: Specialized in backend security coding practices
  • frontend-security-coder.md: Focused on frontend security implementations
  • mobile-security-coder.md: Dedicated to mobile app security coding

Key Improvements

  • Shortened descriptions to 2-3 lines to match repository standards
  • All agents use \model: opus\ for security-critical tasks
  • Clear differentiation from existing \security-auditor.md:
  • These agents focus on hands-on coding and implementation
  • \security-auditor\ focuses on high-level auditing and assessment
  • Complete mobile agent file with all sections properly formatted
  • Comprehensive coverage of platform-specific security patterns

Use Cases

  • Backend Security Coder: API security, database protection, authentication systems
  • Frontend Security Coder: XSS prevention, CSP implementation, DOM security
  • Mobile Security Coder: WebView security, biometric auth, cross-platform security

These agents enhance the existing security capabilities and provide specialized expertise for different development domains while maintaining clear boundaries with existing security tools.

@Bortus-AI
Copy link

Nice. Trying these out now

Copy link
Owner

@wshobson wshobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request Changes - PR #62 Review

Thank you for contributing these security-focused agents. While they provide valuable coverage, several issues need addressing:

Critical Issues

  1. Incomplete file: mobile-security-coder.md is truncated at line 153, missing Response Approach and Example Interactions sections
  2. Model inconsistency: Consider using model: opus instead of sonnet for security-critical agents (matching security-auditor.md)

Required Improvements

  • Shorten descriptions to 2-3 lines to match repository standards
  • Address overlap with existing security-auditor.md - please add clear differentiation or consolidate
  • Add use-case boundaries: Specify when to use these agents vs existing security-auditor

Minor Fixes

  • Remove repetitive phrasing in behavioral traits (backend-security-coder.md:89-90)
  • Complete the mobile agent's cross-platform examples

Please fix the truncated file and address the model/overlap concerns. The agents show promise but need these refinements before merging.

- Change model from sonnet to opus for all three security coder agents
- Add clear differentiation from security-auditor with use-case boundaries
- Implement environment-specific clickjacking protection guidance
- Add WebView data cleanup recommendations for mobile security
- Standardize terminology to use 'allowlist' consistently
- Complete cross-platform security examples for mobile development
- Fix repetitive phrasing in behavioral traits
- Align all security practices with reference material requirements
…curity agent

- Shorten descriptions in all three security coder agents to 2-3 lines
- Ensure mobile-security-coder.md is complete and properly formatted
- Address overlap concerns with existing security-auditor.md
- All agents now use model: opus for security-critical tasks
@ChanMeng666 ChanMeng666 changed the title feat: add three security coding expert agents for backend, frontend, and mobile development feat: Add comprehensive security coding expert agents with improved descriptions Sep 14, 2025
@ChanMeng666
Copy link
Contributor Author

Request Changes - PR #62 Review

Thank you for contributing these security-focused agents. While they provide valuable coverage, several issues need addressing:

Critical Issues

  1. Incomplete file: mobile-security-coder.md is truncated at line 153, missing Response Approach and Example Interactions sections
  2. Model inconsistency: Consider using model: opus instead of sonnet for security-critical agents (matching security-auditor.md)

Required Improvements

  • Shorten descriptions to 2-3 lines to match repository standards
  • Address overlap with existing security-auditor.md - please add clear differentiation or consolidate
  • Add use-case boundaries: Specify when to use these agents vs existing security-auditor

Minor Fixes

  • Remove repetitive phrasing in behavioral traits (backend-security-coder.md:89-90)
  • Complete the mobile agent's cross-platform examples

Please fix the truncated file and address the model/overlap concerns. The agents show promise but need these refinements before merging.


Hi @wshobson , I have made the corresponding updates based on your revision requests. 👌

- Updated README.md with table-based organization
- Added comprehensive TDD support with tdd-orchestrator.md
- Added examples/tdd-usage.md for TDD workflow examples
- Enhanced test-automator.md with TDD capabilities
- Preserved existing security coder agents
Copy link
Owner

@wshobson wshobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ChanMeng666 . Looks great!

@wshobson wshobson merged commit 7c55783 into wshobson:main Sep 15, 2025
destenson pushed a commit to destenson/wshobson--agents that referenced this pull request Nov 1, 2025
feat: Add comprehensive security coding expert agents with improved descriptions
toplyr-narfur pushed a commit to toplyr-narfur/urbit-agents that referenced this pull request Nov 13, 2025
feat: Add comprehensive security coding expert agents with improved descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants