feat: Add comprehensive security coding expert agents with improved descriptions#62
feat: Add comprehensive security coding expert agents with improved descriptions#62wshobson merged 4 commits intowshobson:mainfrom
Conversation
…and mobile development
|
Nice. Trying these out now |
wshobson
left a comment
There was a problem hiding this comment.
Request Changes - PR #62 Review
Thank you for contributing these security-focused agents. While they provide valuable coverage, several issues need addressing:
Critical Issues
- Incomplete file:
mobile-security-coder.mdis truncated at line 153, missing Response Approach and Example Interactions sections - Model inconsistency: Consider using
model: opusinstead ofsonnetfor security-critical agents (matchingsecurity-auditor.md)
Required Improvements
- Shorten descriptions to 2-3 lines to match repository standards
- Address overlap with existing
security-auditor.md- please add clear differentiation or consolidate - Add use-case boundaries: Specify when to use these agents vs existing security-auditor
Minor Fixes
- Remove repetitive phrasing in behavioral traits (backend-security-coder.md:89-90)
- Complete the mobile agent's cross-platform examples
Please fix the truncated file and address the model/overlap concerns. The agents show promise but need these refinements before merging.
- Change model from sonnet to opus for all three security coder agents - Add clear differentiation from security-auditor with use-case boundaries - Implement environment-specific clickjacking protection guidance - Add WebView data cleanup recommendations for mobile security - Standardize terminology to use 'allowlist' consistently - Complete cross-platform security examples for mobile development - Fix repetitive phrasing in behavioral traits - Align all security practices with reference material requirements
…curity agent - Shorten descriptions in all three security coder agents to 2-3 lines - Ensure mobile-security-coder.md is complete and properly formatted - Address overlap concerns with existing security-auditor.md - All agents now use model: opus for security-critical tasks
Hi @wshobson , I have made the corresponding updates based on your revision requests. 👌 |
- Updated README.md with table-based organization - Added comprehensive TDD support with tdd-orchestrator.md - Added examples/tdd-usage.md for TDD workflow examples - Enhanced test-automator.md with TDD capabilities - Preserved existing security coder agents
wshobson
left a comment
There was a problem hiding this comment.
Thanks for your contribution @ChanMeng666 . Looks great!
feat: Add comprehensive security coding expert agents with improved descriptions
feat: Add comprehensive security coding expert agents with improved descriptions
This PR adds three new security-focused coding expert agents with shortened descriptions and improved clarity:
New Agents Added
Key Improvements
Use Cases
These agents enhance the existing security capabilities and provide specialized expertise for different development domains while maintaining clear boundaries with existing security tools.