Update package versions in ballerina extensions#1411
Conversation
- Bumped VSCode engine version to ^1.100.0 in ballerina-extension. - Updated webpack-dev-server to version 5.2.3 in ballerina-visualizer. - Upgraded html-to-image to version 1.11.11 in both graphql-design-diagram and persist-layer-diagram.
WalkthroughMultiple package.json files updated across workspaces to bump dependency and toolchain version ranges (VS Code engine, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@workspaces/ballerina/ballerina-extension/package.json`:
- Around line 17-18: Update package.json so the declared VS Code engine
(^1.100.0) is consistent with the types and e2e setup: bump the `@types/vscode`
dependency (the entry named "@types/vscode") to a version that matches 1.100
(e.g., 1.100.x or ^1.100.0) and modify the e2e-test-setup script (the script
named "e2e-test-setup" that downloads a specific VS Code tarball) to pull VS
Code 1.100.x instead of 1.83.1; also search the file for any remaining "1.83.1"
literals and update them to the chosen 1.100.x value so types, local tooling and
tests align with the engines constraint.
…aml to fix vulnerability
…and pnpm-lock.yaml
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
workspaces/wso2-platform/wso2-platform-extension/package.json (1)
15-15:⚠️ Potential issue | 🟠 Major
e2e-test-setupstill downloads VS Code 1.83.1, which doesn't satisfy the^1.100.0engine constraint.Same issue as in
choreo-extension/package.json— the engine is^1.100.0(Line 15) bute2e-test-setup(Line 224) pulls VS Code1.83.1. The extension won't activate in that test environment.Proposed fix
- "e2e-test-setup": "npx extest get-vscode -c 1.83.1 && npx extest get-chromedriver -c 1.83.1 && npx extest install-vsix -f $(ls vsix/*.vsix)", + "e2e-test-setup": "npx extest get-vscode -c 1.100.0 && npx extest get-chromedriver -c 1.100.0 && npx extest install-vsix -f $(ls vsix/*.vsix)",Also applies to: 224-224
workspaces/choreo/choreo-extension/package.json (1)
14-14:⚠️ Potential issue | 🟠 MajorUpdate
e2e-test-setupscript to match the^1.100.0VS Code engine requirement.The
vscodeengine constraint (line 14) and@types/vscodedependency (line 194) are both at version 1.100.0, but thee2e-test-setupscript (line 174) still downloads VS Code 1.83.1, creating a version mismatch that will cause the extension to fail activation in the test environment. This fix has already been applied inballerina-extension/package.json(line 1204).Proposed fix
- "e2e-test-setup": "npx extest get-vscode -c 1.83.1 && npx extest get-chromedriver -c 1.83.1 && npx extest install-vsix -f $(ls vsix/*.vsix)", + "e2e-test-setup": "npx extest get-vscode -c 1.100.0 && npx extest get-chromedriver -c 1.100.0 && npx extest install-vsix -f $(ls vsix/*.vsix)",
🧹 Nitpick comments (1)
workspaces/ballerina/ballerina-core/package.json (1)
53-55: Pre-existing: Node engine constraint>=0.10.3 <16is severely outdated.Node 16 reached EOL in September 2023. This isn't introduced by this PR, but worth addressing soon since the rest of the repo uses much newer Node versions.
Fixing major issues in Ballerina extension after fixing package version with #1223
Summary by CodeRabbit