Update keyboard_widget.go to process event keys before regular keys#2028
Open
cbRoy wants to merge 2 commits intowtfutil:trunkfrom
Open
Update keyboard_widget.go to process event keys before regular keys#2028cbRoy wants to merge 2 commits intowtfutil:trunkfrom
cbRoy wants to merge 2 commits intowtfutil:trunkfrom
Conversation
Swapped the processing of event presses and regular key presses. This prevents modifier events from being ignored when they use the same defined regular keys, such as j and C-j
Collaborator
|
Hey @cbRoy. Thank you for the PR. Did you test this change yourself? If so, on what OS? I'm testing on macOS and it's not fixed for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swapped the processing of event presses and regular key presses. This prevents modifier events from being ignored when they use the same defined regular keys, such as j and C-j
fixes #2027