Skip to content

Update scalajs-compiler to 1.20.1 #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xerial merged 1 commit into from
Sep 10, 2025
Merged

Update scalajs-compiler to 1.20.1 #4033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airspec/project/plugin.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.13.1")
addDependencyTreePlugin

// For Scala.js
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0")
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.20.1")
addSbtPlugin("org.scala-js" % "sbt-scalajs" % SCALAJS_VERSION)
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "0.21.1")
libraryDependencies ++= (
Expand Down
2 changes: 1 addition & 1 deletion project/plugin.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ addSbtPlugin("org.wvlet.airframe" % "sbt-airframe" % SBT_AIRFRAME_VERSION)
addDependencyTreePlugin

// For Scala.js
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0")
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.20.1")

@gemini-code-assist gemini-code-assist Bot Sep 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The SCALAJS_VERSION is also defined in airspec/project/plugin.sbt and sbt-airframe/src/sbt-test/sbt-airframe/js-client/project/plugins.sbt. To follow the DRY (Don't Repeat Yourself) principle and avoid potential version inconsistencies, consider defining this version in a single location. Given the project structure, this could be achieved by reading the version from a properties file at the root of the project in each plugin.sbt file. While Scala Steward handles these updates automatically, centralizing the version would improve manual maintenance in the future.

addSbtPlugin("org.scala-js" % "sbt-scalajs" % SCALAJS_VERSION)
addSbtPlugin("ch.epfl.scala" % "sbt-scalajs-bundler" % "0.21.1")
libraryDependencies ++= (
Expand Down
2 changes: 1 addition & 1 deletion sbt-airframe/src/sbt-test/sbt-airframe/js-client/project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ sys.props.get("plugin.version") match {

// For Scala.js
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.3.2")
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.19.0")
val SCALAJS_VERSION = sys.env.getOrElse("SCALAJS_VERSION", "1.20.1")
addSbtPlugin("org.scala-js" % "sbt-scalajs" % SCALAJS_VERSION)
Loading