This repository was archived by the owner on Oct 24, 2024. It is now read-only.
Merged
Conversation
This was referenced Aug 24, 2021
Member
Author
|
In a twist of events this PR has ended up accidentally successfully implementing reduce and cumulative methods such as However I still haven't got numpy ufuncs or binary arithmetic operations like multiply working, but I'll discuss them in separate issue. |
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
Expose dataset reduce operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WIP attempt to get operations like
*and+working onDatasetNodeobjects.Idea is to copy the pattern used to add these operators to
xarray.Dataset, whereDatasetinherits fromDatasetArithmetic.DatasetArithmeticitself inherits from about 5 different Mixin classes, which I don't particularly want to regenerate, especially asDatasetOpsMixinis generated by templating in xarray. Here we instead just want to take the methods defined onDatasetArithmeticand decorate them withmap_over_subtree, to get aDataTreeArithmeticobject to inherit from.Problem is at the moment I'm getting errors like this:
I don't understand why this is happening because
__mul__and__rmul__are definitely defined on thedtobjects. (Could it be because those methods get defined only once the object instance has been created, and not when the class is defined?)