This repository was archived by the owner on Oct 24, 2024. It is now read-only.
Moves Tree Contents until after simpsons DataTree is defined.#300
Closed
flamingbear wants to merge 5 commits intoxarray-contrib:mainfrom
flamingbear:patch-2
Closed
Moves Tree Contents until after simpsons DataTree is defined.#300flamingbear wants to merge 5 commits intoxarray-contrib:mainfrom flamingbear:patch-2
flamingbear wants to merge 5 commits intoxarray-contrib:mainfrom
flamingbear:patch-2
Conversation
Since I'm reading the docs and don't know sphinx very well. I saw a problem with the is_hollow description and fixed.
Contributor
Author
|
Maybe I should have batched these up. Because I see another quick fix. |
owenlittlejohns
approved these changes
Jan 17, 2024
Contributor
Author
|
Since this isn't merged, I'm going to toss in the two other quick fixes I saw. |
slevang
added a commit
to slevang/datatree
that referenced
this pull request
Jan 18, 2024
slevang
added a commit
to slevang/datatree
that referenced
this pull request
Jan 18, 2024
Contributor
Author
|
Yeah, that was me being not particularly bright and mucking with merging my datatree and xarray repos. I will update this again with a fresh PR. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I'm reading the docs and don't know sphinx very well, I saw a problem with the is_hollow description and fixed it.
It may make more sense to have
Tree Contents: Hollow TreesaboveManipulating Trees: Subsetting Tree Nodes, but thesimpsonsDataTree is undefined. Rather than create a new tree for this example I just moved it.In addition to moving it I changed the description from a python method to the py:class so that the rendering didn't include the incorrect parens.
The updated docs after rebuilding show the tree is not hollow rather than
NameError: name 'simpsons' is not definedas it did beforeAlso tossed in a visualization of the subsetting
dt.match(*.B)result and a typowo->two