import_srpm: allow to pass a url as source file#740
Open
glehmann wants to merge 1 commit into
Open
Conversation
stormi
reviewed
Aug 5, 2025
| source_rpm = args.source_rpm | ||
| if is_url(source_rpm): | ||
| # get the src.rpm locally, and continue with the actual file | ||
| local_filename = f'/tmp/{os.path.basename(source_rpm)}' |
Member
There was a problem hiding this comment.
Should use a temporary directory known not to conflict with anything
Member
There was a problem hiding this comment.
And it could also self-destroy at the end, as python's tempfile (IIRC) allows?
glehmann
force-pushed
the
gln/srpm-url-source-qxor
branch
from
72275f4 to
09f205c
Compare
Member
|
@glehmann ready for re-review? |
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/srpm-url-source-qxor
branch
from
09f205c to
40a9d07
Compare
Member
|
@glehmann you pushed after my last question but didn't answer nor ask for a re-review. Thus the PR stalled. What's the current status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we don't even have to manually download the srpm.