Fix #18: encode() only if type is unicode (only for Py2)#23

Closed

bernhardkaindl wants to merge 26 commits intomasterfrom

testsuite-driven-py3-xml-getText-encode

Commits on Jan 20, 2023

python3: use six.string_types not version-dependant types
ydirson
committed
python3: use "six.ensure_binary" and "six.ensure_text" for str/bytes conversion
ydirson
committed
Remove direct call's to file's constructor and replace them with calls to

brettcannon
authored and
ydirson
committed
python3: xcp.net.mac: use six.python_2_unicode_compatible for stringification
ydirson
committed
xcp.net.ifrename.logic: use "logger.warning", "logger.warn" is deprecated
ydirson
committed
python3: use raw strings for regexps, fixes insufficient quoting
ydirson
committed
test_dom0: mock "open()" in a python3-compatible way
ydirson
committed
ifrename: don't rely on dict ordering in tests
ydirson
committed
test_cpio: ensure paths are handled as text
ydirson
committed
cpiofile: migrate last "list.sort()" call still using a "cmp" argument
ydirson
committed
WIP python3: fix xmlunwrap and its test to align with the use of bytes
ydirson
committed
xcp.repository: switch from md5 to hashlib.md5
ydirson
committed
WIP xcp.repository: switch from ConfigParser to configparser
ydirson
committed
test: use parametrized tests
ydirson
committed
WIP test_accessor: check for I/O on binary files
ydirson
committed
WIP test_accessor: write into copy file as binary
ydirson
committed
Pylint complements: honor len-as-condition convention
ydirson
committed
Pylint complements: whitespace in expressions
ydirson
committed
Pylint complements: test_ifrename_logic: disable "no-member" warning
ydirson
committed
Pylint complements: avoid no-else-raise "refactor" issues
ydirson
committed
CI: also run tests with python3
ydirson
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix #18: encode() only if type is unicode (only for Py2)#23

Fix #18: encode() only if type is unicode (only for Py2)#23
bernhardkaindl wants to merge 26 commits intomasterfrom
testsuite-driven-py3-xml-getText-encode

Commits on Jan 20, 2023

python3: use six.string_types not version-dependant types

python3: use "six.ensure_binary" and "six.ensure_text" for str/bytes conversion

Remove direct call's to file's constructor and replace them with calls to

python3: xcp.net.mac: use six.python_2_unicode_compatible for stringification

xcp.net.ifrename.logic: use "logger.warning", "logger.warn" is deprecated

python3: use raw strings for regexps, fixes insufficient quoting

test_dom0: mock "open()" in a python3-compatible way

ifrename: don't rely on dict ordering in tests

test_cpio: ensure paths are handled as text

cpiofile: migrate last "list.sort()" call still using a "cmp" argument

WIP python3: fix xmlunwrap and its test to align with the use of bytes

xcp.repository: switch from md5 to hashlib.md5

WIP xcp.repository: switch from ConfigParser to configparser

test: use parametrized tests

WIP test_accessor: check for I/O on binary files

WIP test_accessor: write into copy file as binary

Pylint complements: honor len-as-condition convention

Pylint complements: whitespace in expressions

Pylint complements: test_ifrename_logic: disable "no-member" warning

Pylint complements: avoid no-else-raise "refactor" issues

CI: also run tests with python3

Commits on Apr 24, 2023

xcp/xmlunwrap.py:getText() Fix #18: encode only if not str(means: unicode) for Py2

xcp/xmlunwrap.py:getText() follow-up for #18: Add type comments

xcp/xmlunwrap.py: if len(matching) == 0 -> if not matching

xcp/xmlunwrap.py: (default == None) -> default is None

xcp/xmlunwrap.py: Apply fixes for remarks by code checkers