xcp/repository.py: Fixup unclosed file warning left from #27 #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup the unclosed file warning which was introduced by commit 08f000 (xcp.repository: switch from ConfigParser to configparser) in xenserver#27. PS: Because I'm using pre-commit now, also remove a line which had trailing spaces Signed-off-by: Bernhard Kaindl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 75.40% 75.41%
=======================================
Files 21 21
Lines 3464 3465 +1
=======================================
+ Hits 2612 2613 +1
Misses 852 852
Flags with carried forward coverage won't be shown. Click here to find out more.
|
psafont
approved these changes
Jun 7, 2023
rosslagerwall
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple 2-line PR:
Fixup the unclosed file warning which was introduced by commit 08f000
(xcp.repository: switch from ConfigParser to configparser) from PR Initial Python3 support with Test-Driven-Development enforced by CI (with git diff coverage and diff lint checking) + mypy, pyre and pytype #27.
PS: Because I'm using pre-commit now:
Also remove a line which had trailing spaces