mips: Rename MIPSr1_ASM to MIPSr2dsp_ASM to reflect true requirements.#109
Closed
speachy wants to merge 1 commit intoxiph:masterfrom
Closed
mips: Rename MIPSr1_ASM to MIPSr2dsp_ASM to reflect true requirements.#109speachy wants to merge 1 commit intoxiph:masterfrom
speachy wants to merge 1 commit intoxiph:masterfrom
Conversation
Code actually requires a mips32r2 core with dsp or dsp2 extensions, so update the #define appropriately. Signed-off-by: Solomon Peachy <pizza@shaftnet.org>
Member
|
Can you contact the original authors of the patch to see what they have to say about it. I don't really have any way to test that arch. |
|
Does it also require hardware floating point? |
|
What's the correct way of building opus for mips32r2 (mipsel, little-endian)? How to test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the mips code in opus requires a mips32r2 core with dsp or dsp2 extensions, so
update the #define to document this appropriately.
I did not rename the various header files that have "mipsr1" in their name, as that seemed like unnecessary churn.
Signed-off-by: Solomon Peachy pizza@shaftnet.org