@SectionBuilder#2235
Merged
mats-claassen merged 5 commits intoxmartlabs:masterfrom Nov 16, 2022
RomanPodymov:feature/section_builder
Merged
@SectionBuilder#2235mats-claassen merged 5 commits intoxmartlabs:masterfrom RomanPodymov:feature/section_builder
mats-claassen merged 5 commits intoxmartlabs:masterfrom
RomanPodymov:feature/section_builder
Conversation
Update code
Code update
Member
mats-claassen
left a comment
mats-claassen
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution. Looks great overall, just one comment
| } | ||
|
|
||
| public static func buildExpression(_ expression: String?) -> [BaseRow] { | ||
| [.init(tag: expression)] |
Member
There was a problem hiding this comment.
This would be instantiating a BaseRow (not a concrete Row). Not sure about how this would be useful
Contributor
Author
There was a problem hiding this comment.
Hello @mats-claassen
Exactly, deleted it.
Member
|
Also, yes please add documentation to the Readme about this feature |
Contributor
Author
Done. |
mats-claassen
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for Eureka.
Added the first
@resultBuilderto the project. If you like it, I will add more.@mats-claassen Or should I add some documentation for
@SectionBuilder?