Add support for App Extensions#97
Conversation
kabiroberai
left a comment
There was a problem hiding this comment.
this is great, thanks! left one quick comment but feel free to ping me once it's ready for broad review.
now it is possible to create and launch app extensions. In the future we can add support for ExtensionKit-like extensions.
|
@kabiroberai I am 90% done with App Extensions (excluding ExtensionKit, iMessage). The only thing missing is ensuring XcodeProj generates a valid folder with all products. If you like you can go over my code base and let me know if you have any feedback. :) |
|
@erikbdev thanks, I'll look at this as soon as I can! In the meantime do you mind fixing the SwiftLint failures? You can run |
Will update in another pull request. This reverts commit 7749f2b.
This pull request resolves potential clock drift between ASC and bearer token. Ref: #97 (comment)
There was a problem hiding this comment.
lgtm, this is great! will do some final testing and merge shortly if everything works.
A few things we probably want to do as followups:
- [High priority] support ExtensionKit
- [Medium priority] deduplicate frameworks. i.e. if a framework is used across multiple products (multiple extensions or main target + extension), pull it out into the main target's Frameworks directory and reuse it.
- [Low priority] create an upstream SwiftPM issue about
describeandshow-dependencieshaving logs that are sent to stdout. I think the ideal fix here would be fordescribeto offer a-oparameter because that entirely skirts around the issue of noisy stdout logs.
|
Another idea for a followup: I wonder whether a shorthand to avoid requiring extensions:
- product: MyWidget
NSExtensionPointIdentifier: com.apple.widgetkit-extension
- product: MyGenericExt
EXExtensionPointIdentifier: com.example.genericor maybe extensions:
- product: MyWidget
extensionPoint: com.apple.widgetkit-extension
- product: MyGenericExt
type: ExtensionKit
extensionPoint: com.example.generic |
This looks interesting, we could also possibly infer the type of extension based on the |
This is just the provisioning side, still need to support bundling into the Extensions dir in a separate PR
we’re using bForce=true in zsign so the outer bundle will overwrite the inner bundle
hmm we could but that feels a bit too magical to me. I think being explicit about it (either via
I think we should just require an |
This pull request resolves potential clock drift between ASC and bearer token. Ref: xtool-org/xtool#97 (comment)
This pull request resolves potential clock drift between ASC and bearer token. Ref: xtool-org/xtool#97 (comment)
This pull request adds support for Apple's App Extensions.
Closes: #45