Conversation
alexlopashev
changed the title
|
FYI ypy is not maintained anymore. See pycrdt instead. |
Hi @davidbrochart, in fact this is PR to revive this library, and I'm volunteered to be new maintainer. |
|
Maybe ping Kevin in #148? |
I've reached out directly over email couple weeks ago, but good point, will report on the issue as well, thanks! |
|
Unless there are other suggestions, I believe this change set is ready to be merged and published. |
|
|
||
| /// Cancels the callback of an observer using the `observation_d` returned from the `observe` method. | ||
| pub fn unobserve(&mut self, observation_d: ObservationId) -> PyResult<bool> { | ||
| pub fn unobserve(&mut self, observation_d: ObservationId) -> PyResult<()> { |
There was a problem hiding this comment.
Wouldn't be better to implement close method on ObservationId? This way you could potentially use it in with statements. Not a single thing in unobserve method requires self to be a param either.
|
@alexlopashev I love this PR! Merging this (or even a bump to 0.22 now) would be super useful. Is there any way I can help? |
4 participants
No description provided.