Changed AcrylicDNS binding address to localhost loopback address#15
Merged
yCodeTech merged 1 commit intoyCodeTech:masterfrom Aug 6, 2024
Merged
Changed AcrylicDNS binding address to localhost loopback address#15yCodeTech merged 1 commit intoyCodeTech:masterfrom
yCodeTech merged 1 commit intoyCodeTech:masterfrom
Conversation
…void conflicting with WSL2 dependency. See: microsoft/WSL#4364 (comment)
yCodeTech
added a commit
that referenced
this pull request
Jun 9, 2025
…om SourceForge. Removed: - Removed all `Acrylic` bin files. Added: - Added new `Acrylic` class with the namespace `Valet\Packages`, and extending the base `Package` class. This class will never clash with the normal `Acrylic` class because of the different namespaces. Because SourceForge doesn't have a proper API for releases, we have to use the `best_release.json` endpoint to obtain the latest `.exe` version. But because the json file only lists the download URL of the standalone `.exe` file, we have to replace the filename to get the download URL for the portable zip version (`Acrylic-Portable.zip`). - Added new `Acrylic_IPv4_Binding_Address.ini` stub file to add the custom IPv4 binding localhost loopback address as fixed in PR #15. - Added a `changeLocalIpv4BindingAddress` method to replace the default value of `LocalIPv4BindingAddress` with our custom value from the new stub file.
yCodeTech
added a commit
that referenced
this pull request
Oct 20, 2025
…om SourceForge. Removed: - Removed all `Acrylic` bin files. Added: - Added new `Acrylic` class with the namespace `Valet\Packages`, and extending the base `Package` class. This class will never clash with the normal `Acrylic` class because of the different namespaces. Because SourceForge doesn't have a proper API for releases, we have to use the `best_release.json` endpoint to obtain the latest `.exe` version. But because the json file only lists the download URL of the standalone `.exe` file, we have to replace the filename to get the download URL for the portable zip version (`Acrylic-Portable.zip`). - Added new `Acrylic_IPv4_Binding_Address.ini` stub file to add the custom IPv4 binding localhost loopback address as fixed in PR #15. - Added a `changeLocalIpv4BindingAddress` method to replace the default value of `LocalIPv4BindingAddress` with our custom value from the new stub file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed AcrylicDNS binding address to localhost loopback address to avoid conflicting with WSL2 dependency.
See: microsoft/WSL#4364 (comment)