Skip to content

Quote command so paths with whitespace work#663

Merged
bestander merged 1 commit intoyarnpkg:masterfrom
AlicanC:alicanc-whitespace
Oct 11, 2016
Merged

Quote command so paths with whitespace work#663
bestander merged 1 commit intoyarnpkg:masterfrom
AlicanC:alicanc-whitespace

Conversation

@AlicanC
Copy link
Copy Markdown
Contributor

@AlicanC AlicanC commented Oct 11, 2016

Summary

If the project is in a path with whitespace (/Users/bleh/My Stuff/project/), running binaries (yarn run eslint) doesn't work. I quoted cmd to solve this issue.

A better way to solve this could be passing cmd and args separately down to child.jss spawn() and quoting or escaping there, but that would require too much API change.

Comments?

Test plan

Reproduce:

mkdir "some dir"
cd "some dir"
git clone git@github.com:yarnpkg/yarn.git
cd yarn
yarn
yarn run eslint

@bestander bestander merged commit e169535 into yarnpkg:master Oct 11, 2016
@nodesocket
Copy link
Copy Markdown

nodesocket commented Oct 12, 2016

Seems this commit broke yarn run command arg1 arg2.

See: issue 733

@AlicanC AlicanC deleted the alicanc-whitespace branch October 12, 2016 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants