Skip to content

Move VolumeBalancer wakeup interval to storage.proto config as VolumeBalancerWakeupInterval#5681

Closed
efimov-ivan-yteam wants to merge 1 commit intomainfrom
users/efimov-ivan/move-balancer-wakeup-interval-to-config
Closed

Move VolumeBalancer wakeup interval to storage.proto config as VolumeBalancerWakeupInterval#5681
efimov-ivan-yteam wants to merge 1 commit intomainfrom
users/efimov-ivan/move-balancer-wakeup-interval-to-config

Conversation

@efimov-ivan-yteam
Copy link
Copy Markdown
Collaborator

@efimov-ivan-yteam efimov-ivan-yteam commented Apr 7, 2026

Moved hard-coded value to config

…BalancerWakeupInterval

Original value is kept as default
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 263s): all tests PASSED for commit 0008cc5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
873 873 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 222s): all tests PASSED for commit 0008cc5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1096 1096 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 4740s): all tests PASSED for commit 0008cc5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3523 3523 0 0 0 0 0

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 1921s): some tests FAILED for commit 0008cc5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
5987 5610 0 311 0 66 0

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 704s): some tests FAILED for commit 0008cc5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
433 59 0 325 0 49 0

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 701s): some tests FAILED for commit 0008cc5.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
431 57 0 324 0 50 0


ctx.Schedule(Timeout, new TEvents::TEvWakeup);
ctx.Schedule(
StorageConfig->GetVolumeBalancerWakeupInterval(),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use UpdateCountersInterval instead

constexpr TDuration UpdateCountersInterval = TDuration::Seconds(15);


ctx.Schedule(Timeout, new TEvents::TEvWakeup());
ctx.Schedule(
StorageConfig->GetVolumeBalancerWakeupInterval(),
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UpdateCountersInterval is a good choice here

constexpr TDuration UpdateCountersInterval = TDuration::Seconds(15);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mass test failures and conflicts

@efimov-ivan-yteam efimov-ivan-yteam marked this pull request as draft April 16, 2026 12:23
@efimov-ivan-yteam
Copy link
Copy Markdown
Collaborator Author

#5901

@efimov-ivan-yteam efimov-ivan-yteam deleted the users/efimov-ivan/move-balancer-wakeup-interval-to-config branch May 6, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants