Skip to content

[Filestore] Do not allocate block buffers or create ropes when two-stage read is disabled #5871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonmyagkov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Filestore] Do not allocate block buffers or create ropes when two-stage read is disabled #5871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions cloud/filestore/libs/storage/service/service_actor_readdata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,18 @@ TReadDataActor::TReadDataActor(

void TReadDataActor::Bootstrap(const TActorContext& ctx)
{
if (ReadRequest.GetIovecs().empty()) {
// BlockBuffer should not be initialized in constructor, because
// creating a block buffer leads to memory allocation (and
// initialization) which is heavy and we would like to execute that on a
// separate thread (instead of this actor's parent thread)
BlockBuffer->ReserveAndResize(ReadRequest.GetLength());
TargetBuffers = CreateRope(BlockBuffer->begin(), BlockBuffer->size());
} else {
TargetBuffers = CreateRope(ReadRequest.GetIovecs());
if (UseTwoStageRead) {
if (ReadRequest.GetIovecs().empty()) {
// BlockBuffer should not be initialized in constructor, because
// creating a block buffer leads to memory allocation (and
// initialization) which is heavy and we would like to execute that
// on a separate thread (instead of this actor's parent thread)
BlockBuffer->ReserveAndResize(ReadRequest.GetLength());
TargetBuffers =
CreateRope(BlockBuffer->begin(), BlockBuffer->size());
} else {
TargetBuffers = CreateRope(ReadRequest.GetIovecs());
}
}

// Registering InFlightRequest here for the same reason - it's quite
Expand Down
Loading