Skip to content

[Filestore] should not hang if a Forget request is received before fuse_init#5897

Merged
SvartMetal merged 2 commits intomainfrom
users/svartmetal/tests/3
May 7, 2026
Merged

[Filestore] should not hang if a Forget request is received before fuse_init#5897
SvartMetal merged 2 commits intomainfrom
users/svartmetal/tests/3

Conversation

@SvartMetal
Copy link
Copy Markdown
Collaborator

Notes

Follow-up for #4283.

A "Forget" request is not completed if it is received before fuse_init, because the FUSE handler cannot be called in this case

Issue

Put links to the related issues here

@SvartMetal SvartMetal force-pushed the users/svartmetal/tests/3 branch from 3f8cea0 to 56be906 Compare May 5, 2026 18:46
@SvartMetal SvartMetal marked this pull request as draft May 5, 2026 18:46
@SvartMetal SvartMetal added the large-tests Launch large tests for PR label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 367s): all tests PASSED for commit 56be906.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
979 979 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 2098s): all tests PASSED for commit 56be906.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1455 1455 0 0 0 0 0

🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11602s): some tests FAILED for commit 56be906.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
6537 6535 0 0 1 1 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 501s): all tests PASSED for commit 56be906.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
24 24 0 0 0 0 0

@SvartMetal SvartMetal force-pushed the users/svartmetal/tests/3 branch from 56be906 to a7e0f34 Compare May 6, 2026 18:49
@SvartMetal SvartMetal marked this pull request as ready for review May 6, 2026 18:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 365s): all tests PASSED for commit a7e0f34.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
979 979 0 0 0 0 0

Copy link
Copy Markdown

@robot-vibe-db robot-vibe-db Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

  • Minor | High: Commenting out fuse_reply_none creates an implicit contract that all consumers of virtiofsd/static must provide their own implementation — cloud/contrib/virtiofsd/fuse_lowlevel.c:361
  • Minor | Medium: The cloud/contrib/virtiofsd/dynamic library target may fail to build or have runtime issues with the now-unresolved fuse_reply_none symbol — cloud/contrib/virtiofsd/dynamic/ya.make
  • Nit | High: Unrelated test cleanup (default timer parameter removal) bundled with the bug fix — cloud/filestore/libs/vfs_fuse/fs_ut.cpp:3124

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

Comment thread cloud/contrib/virtiofsd/fuse_lowlevel.c
Comment thread cloud/filestore/libs/vfs_fuse/vhost/fuse_virtio.c
Comment thread cloud/filestore/libs/vfs_fuse/fs_ut.cpp
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 289s): all tests PASSED for commit a7e0f34.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
979 979 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 1948s): all tests PASSED for commit a7e0f34.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1455 1455 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7121s): all tests PASSED for commit a7e0f34.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3689 3689 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11149s): all tests PASSED for commit a7e0f34.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
6539 6538 0 0 0 1 0

qkrorlqr
qkrorlqr previously approved these changes May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 326s): all tests PASSED for commit a19ec7a.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
979 979 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 1920s): all tests PASSED for commit a19ec7a.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
1455 1455 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7189s): all tests PASSED for commit a19ec7a.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
3689 3689 0 0 0 0 0

🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11753s): all tests PASSED for commit a19ec7a.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
6539 6538 0 0 0 1 0

@SvartMetal SvartMetal merged commit c280bbd into main May 7, 2026
23 of 26 checks passed
@SvartMetal SvartMetal deleted the users/svartmetal/tests/3 branch May 7, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai_reviewed large-tests Launch large tests for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants