[Filestore] should not hang if a Forget request is received before fuse_init#5897
[Filestore] should not hang if a Forget request is received before fuse_init#5897SvartMetal merged 2 commits intomainfrom
Conversation
3f8cea0 to
56be906
Compare
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 367s): all tests PASSED for commit 56be906.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 2098s): all tests PASSED for commit 56be906.
🔴 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11602s): some tests FAILED for commit 56be906.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 501s): all tests PASSED for commit 56be906.
|
56be906 to
a7e0f34
Compare
There was a problem hiding this comment.
AI Review Summary
Verdict: ✅ No critical issues found
Critical issues
No critical issues found.
Other findings
- Minor | High: Commenting out
fuse_reply_nonecreates an implicit contract that all consumers ofvirtiofsd/staticmust provide their own implementation —cloud/contrib/virtiofsd/fuse_lowlevel.c:361 - Minor | Medium: The
cloud/contrib/virtiofsd/dynamiclibrary target may fail to build or have runtime issues with the now-unresolvedfuse_reply_nonesymbol —cloud/contrib/virtiofsd/dynamic/ya.make - Nit | High: Unrelated test cleanup (default timer parameter removal) bundled with the bug fix —
cloud/filestore/libs/vfs_fuse/fs_ut.cpp:3124
This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 289s): all tests PASSED for commit a7e0f34.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 1948s): all tests PASSED for commit a7e0f34.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7121s): all tests PASSED for commit a7e0f34.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11149s): all tests PASSED for commit a7e0f34.
|
|
Note This is an automated comment that will be appended during run. 🟢 linux-x86_64-relwithdebinfo target: cloud/tasks/,cloud/storage/ (test time: 326s): all tests PASSED for commit a19ec7a.
🟢 linux-x86_64-relwithdebinfo target: cloud/disk_manager/ (test time: 1920s): all tests PASSED for commit a19ec7a.
🟢 linux-x86_64-relwithdebinfo target: cloud/filestore/ (test time: 7189s): all tests PASSED for commit a19ec7a.
🟢 linux-x86_64-relwithdebinfo target: cloud/blockstore/ (test time: 11753s): all tests PASSED for commit a19ec7a.
|
Notes
Follow-up for #4283.
A "Forget" request is not completed if it is received before fuse_init, because the FUSE handler cannot be called in this case
Issue
Put links to the related issues here