Added availabilityPeriod to AlterConsumerSettings#616
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release_v2.3.32 #616 +/- ##
=====================================================
+ Coverage 63.37% 64.08% +0.71%
- Complexity 2492 2515 +23
=====================================================
Files 334 334
Lines 14027 14035 +8
Branches 1424 1425 +1
=====================================================
+ Hits 8889 8995 +106
+ Misses 4489 4388 -101
- Partials 649 652 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for configuring availabilityPeriod when altering an existing topic consumer, and extends integration tests to cover both valid and invalid combinations.
Changes:
- Add
availabilityPeriodfield + builder setter/getter toAlterConsumerSettings. - Populate
setSetAvailabilityPeriodinTopicClientImpl.alterTopic()when provided. - Extend
YdbTopicsIntegrationTestwith new tests for invalid/validAlterConsumerSettingsupdates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
topic/src/main/java/tech/ydb/topic/settings/AlterConsumerSettings.java |
Adds availabilityPeriod to alter-consumer settings (field, getter, builder setter). |
topic/src/main/java/tech/ydb/topic/impl/TopicClientImpl.java |
Serializes availabilityPeriod into the alter-consumer protobuf request. |
topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java |
Adds integration coverage for invalid/valid availabilityPeriod usage during consumer alter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1a82a73 to
97d0f45
Compare
pnv1
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.