Skip to content

Added availabilityPeriod to AlterConsumerSettings#616

Merged
alex268 merged 1 commit into
ydb-platform:release_v2.3.32from
alex268:release_v2.3.32
Mar 31, 2026
Merged

Added availabilityPeriod to AlterConsumerSettings#616
alex268 merged 1 commit into
ydb-platform:release_v2.3.32from
alex268:release_v2.3.32

Conversation

@alex268

@alex268 alex268 commented Mar 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@alex268 alex268 requested a review from pnv1 March 31, 2026 08:17
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.08%. Comparing base (3897df6) to head (1a82a73).

Files with missing lines Patch % Lines
...main/java/tech/ydb/topic/impl/TopicClientImpl.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release_v2.3.32     #616      +/-   ##
=====================================================
+ Coverage              63.37%   64.08%   +0.71%     
- Complexity              2492     2515      +23     
=====================================================
  Files                    334      334              
  Lines                  14027    14035       +8     
  Branches                1424     1425       +1     
=====================================================
+ Hits                    8889     8995     +106     
+ Misses                  4489     4388     -101     
- Partials                 649      652       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for configuring availabilityPeriod when altering an existing topic consumer, and extends integration tests to cover both valid and invalid combinations.

Changes:

  • Add availabilityPeriod field + builder setter/getter to AlterConsumerSettings.
  • Populate setSetAvailabilityPeriod in TopicClientImpl.alterTopic() when provided.
  • Extend YdbTopicsIntegrationTest with new tests for invalid/valid AlterConsumerSettings updates.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
topic/src/main/java/tech/ydb/topic/settings/AlterConsumerSettings.java Adds availabilityPeriod to alter-consumer settings (field, getter, builder setter).
topic/src/main/java/tech/ydb/topic/impl/TopicClientImpl.java Serializes availabilityPeriod into the alter-consumer protobuf request.
topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java Adds integration coverage for invalid/valid availabilityPeriod usage during consumer alter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java Outdated
Comment thread topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java Outdated
@alex268 alex268 merged commit 8c098ee into ydb-platform:release_v2.3.32 Mar 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants