Skip to content

Added STANDARD topic retry policy#646

Merged
alex268 merged 1 commit into
ydb-platform:masterfrom
alex268:master
May 4, 2026
Merged

Added STANDARD topic retry policy#646
alex268 merged 1 commit into
ydb-platform:masterfrom
alex268:master

Conversation

@alex268

@alex268 alex268 commented Apr 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov-commenter

codecov-commenter commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.93%. Comparing base (3568ae9) to head (a51c119).

Files with missing lines Patch % Lines
...ain/java/tech/ydb/topic/write/impl/WriterImpl.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #646      +/-   ##
============================================
- Coverage     70.98%   70.93%   -0.06%     
  Complexity     3348     3348              
============================================
  Files           379      379              
  Lines         15856    15862       +6     
  Branches       1663     1664       +1     
============================================
- Hits          11255    11251       -4     
- Misses         3953     3960       +7     
- Partials        648      651       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robot-vibe-db robot-vibe-db Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

  • Nit | Low: Method ensureClosed() reads as "ensure the writer is closed" but actually throws when the writer IS closed. A name like ensureNotClosed() or throwIfClosed() would better convey intent. — WriterImpl.java:88
  • Nit | Low: Double blank line before constructor. — TopicRetryConfig.java:63-64

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

Comment thread topic/src/main/java/tech/ydb/topic/write/impl/WriterImpl.java Outdated
Comment thread topic/src/main/java/tech/ydb/topic/settings/TopicRetryConfig.java
@alex268 alex268 merged commit 56e7f3c into ydb-platform:master May 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants