24-3: Fix bulk operations breaking frozen locks

[snaury]

Changelog entry

Fix bulk operations potentially breaking frozen locks later causing non-serializable commits.

Changelog category

• Bugfix

Additional information

While investigating YDBREQUESTS-4711 it was discovered that TTL (and bulk operations in general) are not waiting for the pipeline to be properly restored after a restart, which allowed them to erroneously break validated (and frozen) locks. This in turn could allow later transactions to violate serializability, which is demonstrated in a unit-test.

Additionally a typo was found in locks.h which caused persistent locks to always restore as read-write locks, even when they are write-only. This could never cause serializability issues, but could cause unnecessary conflicts.

[github-actions]

⚪ 2024-11-26 15:15:27 UTC Pre-commit check for 4bab808 has started.
⚪ 2024-11-26 15:18:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-26 16:02:19 UTC Build successful.
⚪ 2024-11-26 16:02:39 UTC Tests are running...
🔴 2024-11-26 17:19:37 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
14647	13296	0	10	1301	40

🟢 2024-11-26 17:20:25 UTC ydbd size 8.3 GiB changed* by +15.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: d309087	merge: 4bab808	diff	diff %
ydbd size	8 865 410 304 Bytes	8 865 426 104 Bytes	+15.4 KiB	+0.000%
ydbd stripped size	484 023 464 Bytes	484 023 976 Bytes	+512 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2024-11-26 15:15:43 UTC Pre-commit check for 4bab808 has started.
⚪ 2024-11-26 15:18:19 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-26 15:28:21 UTC Build successful.

[github-actions]

⚪ 2024-11-26 15:16:17 UTC Pre-commit check for 4bab808 has started.
⚪ 2024-11-26 15:19:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-26 15:47:03 UTC Build successful.
⚪ 2024-11-26 15:47:22 UTC Tests are running...
🔴 2024-11-26 17:59:49 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
10336	10233	0	26	32	45

🟢 2024-11-26 18:00:38 UTC ydbd size 5.6 GiB changed* by +11.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: ed811cc	merge: 4bab808	diff	diff %
ydbd size	5 997 101 064 Bytes	5 997 112 664 Bytes	+11.3 KiB	+0.000%
ydbd stripped size	1 503 046 400 Bytes	1 503 047 744 Bytes	+1.3 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}