Skip to content

Fix incorrect Uuid serialization for CDC. (#12587)#12601

Merged
dcherednik merged 1 commit intoydb-platform:stable-24-3from
dcherednik:stable-24-3-cdc-uuid-fix
Dec 16, 2024
Merged

Fix incorrect Uuid serialization for CDC. (#12587)#12601
dcherednik merged 1 commit intoydb-platform:stable-24-3from
dcherednik:stable-24-3-cdc-uuid-fix

Conversation

@dcherednik
Copy link
Member

TCell stores uuid as binary data therefore it can contains \0 byte.

Changelog category

  • Bugfix

TCell stores uuid as binary data therefore it can contains \0 byte.
@dcherednik dcherednik requested a review from a team as a code owner December 13, 2024 10:19
@github-actions
Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 10:21:20 UTC Pre-commit check for 459f38a has started.
2024-12-13 10:24:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-13 11:04:32 UTC Build successful.
2024-12-13 11:04:46 UTC Tests are running...
🔴 2024-12-13 12:33:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14697 13350 0 9 1301 37

🟢 2024-12-13 12:34:35 UTC ydbd size 8.3 GiB changed* by -424 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 6d9da7e merge: 459f38a diff diff %
ydbd size 8 873 141 760 Bytes 8 873 141 336 Bytes -424 Bytes -0.000%
ydbd stripped size 484 331 176 Bytes 484 331 496 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 10:21:28 UTC Pre-commit check for 459f38a has started.
2024-12-13 10:24:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-13 10:46:55 UTC Build successful.
2024-12-13 10:47:09 UTC Tests are running...
🔴 2024-12-13 12:48:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10372 10284 0 18 26 44

🟢 2024-12-13 12:49:38 UTC ydbd size 5.6 GiB changed* by +2.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 6d9da7e merge: 459f38a diff diff %
ydbd size 6 002 150 096 Bytes 6 002 153 064 Bytes +2.9 KiB +0.000%
ydbd stripped size 1 504 133 824 Bytes 1 504 135 296 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit df8f59f into ydb-platform:stable-24-3 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants