Skip to content

24-3: Fix follower reads sometimes crashing during split#12804

Merged
snaury merged 1 commit intoydb-platform:stable-24-3from
snaury:bugfix-12140-read-from-dropped-table-24-3
Dec 23, 2024
Merged

24-3: Fix follower reads sometimes crashing during split#12804
snaury merged 1 commit intoydb-platform:stable-24-3from
snaury:bugfix-12140-read-from-dropped-table-24-3

Conversation

@snaury
Copy link
Copy Markdown
Member

@snaury snaury commented Dec 20, 2024

Changelog entry

Fix follower reads sometimes crashing during split.

Changelog category

  • Bugfix

Additional information

It was discovered that when shard splits during a long follower read the node could crash with assertion, trying to read from a table that no longer exists due to their in-memory state and localdb schema diverging. Followers now sync their in-memory state and localdb schema before resuming paused reads, just like they do before starting new reads.

Fixes #12140.

@snaury snaury marked this pull request as ready for review December 20, 2024 07:46
@snaury snaury requested a review from a team as a code owner December 20, 2024 07:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 20, 2024

2024-12-20 07:50:10 UTC Pre-commit check for 96f963f has started.
2024-12-20 07:52:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-20 08:17:14 UTC Build successful.
2024-12-20 08:17:31 UTC Tests are running...
🔴 2024-12-20 10:33:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10372 10273 0 28 29 42

🟢 2024-12-20 10:34:33 UTC ydbd size 5.6 GiB changed* by +5.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 11eb58f merge: 96f963f diff diff %
ydbd size 6 002 539 248 Bytes 6 002 545 264 Bytes +5.9 KiB +0.000%
ydbd stripped size 1 504 193 600 Bytes 1 504 198 656 Bytes +4.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 20, 2024

2024-12-20 07:50:17 UTC Pre-commit check for 96f963f has started.
2024-12-20 07:53:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-20 08:33:26 UTC Build successful.
2024-12-20 08:33:40 UTC Tests are running...
🔴 2024-12-20 10:01:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14695 13345 0 11 1300 39

🟢 2024-12-20 10:02:57 UTC ydbd size 8.3 GiB changed* by +9.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 11eb58f merge: 96f963f diff diff %
ydbd size 8 873 502 784 Bytes 8 873 512 480 Bytes +9.5 KiB +0.000%
ydbd stripped size 484 350 248 Bytes 484 351 016 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury self-assigned this Dec 20, 2024
@snaury snaury merged commit 9ea2252 into ydb-platform:stable-24-3 Dec 23, 2024
@snaury snaury deleted the bugfix-12140-read-from-dropped-table-24-3 branch December 23, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants