Handle bad http headers in requests to YDB#1542
Merged
jepett0 merged 1 commit intoydb-platform:mainfrom Feb 5, 2024
Merged
Conversation
jepett0
force-pushed
the
KIKIMR-19943.uncaught_http_parsing_exception.1
branch
from
6a13421 to
8fbf72d
Compare
|
⚪
|
jepett0
changed the title
|
⚪
|
ijon
approved these changes
Feb 5, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
vporyadke
pushed a commit
to vporyadke/ydb
that referenced
this pull request
Feb 9, 2024
Header without a colon no longer crashes YDB
Merged
Closed
Merged
Merged
This was referenced Feb 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KIKIMR-19943
Modify THttpParser to detect headers without a colon and report an error in this case. Missing colon is detected for both THttpRequest and THttpResponse classes. For some reason, this hasn't been done before.