Skip to content

Don't make lookups on predicate pushdown stage#1560

Merged
ssmike merged 5 commits intoydb-platform:mainfrom
ssmike:delete-over-readranges
Feb 8, 2024
Merged

Don't make lookups on predicate pushdown stage#1560
ssmike merged 5 commits intoydb-platform:mainfrom
ssmike:delete-over-readranges

Conversation

@ssmike
Copy link
Contributor

@ssmike ssmike commented Feb 2, 2024

No description provided.

@ssmike ssmike requested a review from a team as a code owner February 2, 2024 15:13
@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 15:17:10 UTC Pre-commit check for bbbeaa2 has started.
⚪ 2024-02-02 15:17:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-02 15:22:55 UTC Build successful.
⚪ 2024-02-02 15:23:11 UTC Tests are running...
🔴 2024-02-02 17:03:41 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58861 49535 0 29 9265 32

@github-actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

⚪ 2024-02-02 15:17:19 UTC Pre-commit check for bbbeaa2 has started.
⚪ 2024-02-02 15:17:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-02 15:23:47 UTC Build successful.
⚪ 2024-02-02 15:23:59 UTC Tests are running...
🔴 2024-02-02 17:01:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14529 14379 0 54 63 33

@github-actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

⚪ 2024-02-03 16:57:42 UTC Pre-commit check for 6d2000b has started.
⚪ 2024-02-03 16:57:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-03 17:00:48 UTC Build successful.
⚪ 2024-02-03 17:01:01 UTC Tests are running...
🔴 2024-02-03 18:13:44 UTC Test run completed, no test results found for commit e9291cb. Please check build logs.
⚫ 2024-02-03 18:13:47 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

⚪ 2024-02-03 16:57:50 UTC Pre-commit check for 6d2000b has started.
⚪ 2024-02-03 16:57:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-03 17:00:30 UTC Build successful.
⚪ 2024-02-03 17:00:46 UTC Tests are running...
🔴 2024-02-03 18:13:44 UTC Test run completed, no test results found for commit e9291cb. Please check build logs.
⚫ 2024-02-03 18:13:47 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

⚪ 2024-02-03 18:15:00 UTC Pre-commit check for 39c4b8c has started.
⚪ 2024-02-03 18:15:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-03 18:17:13 UTC Build successful.
⚪ 2024-02-03 18:17:23 UTC Tests are running...
🔴 2024-02-03 18:45:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58854 49532 0 18 9267 37

@github-actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

⚪ 2024-02-03 18:17:08 UTC Pre-commit check for 39c4b8c has started.
⚪ 2024-02-03 18:17:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-03 18:19:39 UTC Build successful.
⚪ 2024-02-03 18:19:53 UTC Tests are running...
🔴 2024-02-03 18:49:08 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14528 14351 0 56 85 36

@github-actions
Copy link

github-actions bot commented Feb 4, 2024 •
edited
Loading

⚪ 2024-02-04 18:23:28 UTC Pre-commit check for 9ec9229 has started.
⚪ 2024-02-04 18:23:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-04 18:25:25 UTC Build successful.
⚪ 2024-02-04 18:25:36 UTC Tests are running...
🔴 2024-02-04 18:33:40 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14528 14352 0 54 85 37

@github-actions
Copy link

github-actions bot commented Feb 4, 2024 •
edited
Loading

⚪ 2024-02-04 18:25:04 UTC Pre-commit check for 9ec9229 has started.
⚪ 2024-02-04 18:25:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-04 18:27:10 UTC Build successful.
⚪ 2024-02-04 18:27:23 UTC Tests are running...
🔴 2024-02-04 18:36:32 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58854 49534 0 16 9267 37

@github-actions
Copy link

github-actions bot commented Feb 4, 2024 •
edited
Loading

⚪ 2024-02-04 21:09:40 UTC Pre-commit check for 5d051d0 has started.
⚪ 2024-02-04 21:09:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-04 21:12:18 UTC Build successful.
⚪ 2024-02-04 21:12:33 UTC Tests are running...
🔴 2024-02-04 22:26:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58856 49551 0 10 9265 30

@github-actions
Copy link

github-actions bot commented Feb 4, 2024 •
edited
Loading

⚪ 2024-02-04 21:09:46 UTC Pre-commit check for 5d051d0 has started.
⚪ 2024-02-04 21:09:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-04 21:12:38 UTC Build successful.
⚪ 2024-02-04 21:12:49 UTC Tests are running...
🔴 2024-02-04 22:48:40 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14523 14395 0 38 57 33

@github-actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

⚪ 2024-02-05 00:03:30 UTC Pre-commit check for 5dec7d3 has started.
⚪ 2024-02-05 00:03:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-05 00:05:31 UTC Build successful.
⚪ 2024-02-05 00:05:45 UTC Tests are running...
🔴 2024-02-05 00:14:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58856 49552 0 9 9265 30

@github-actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

⚪ 2024-02-05 00:10:36 UTC Pre-commit check for 5dec7d3 has started.
⚪ 2024-02-05 00:10:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-05 00:12:42 UTC Build successful.
⚪ 2024-02-05 00:13:01 UTC Tests are running...
🔴 2024-02-05 00:16:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14523 14396 0 37 57 33

ulya-sidorina
ulya-sidorina reviewed Feb 7, 2024
View reviewed changes
ydb/core/kqp/opt/logical/kqp_opt_log_effects.cpp

namespace {

bool CanPushFlatMap(const NYql::NNodes::TCoFlatMapBase& flatMap, const NYql::TKikimrTableDescription& tableDesc, const NYql::TParentsMap& parentsMap, TVector<TString> & extraColumns) {
Copy link
Collaborator

@ulya-sidorina ulya-sidorina Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Подобная функция уже есть в kqp_opt_log_indexes.cpp, может вынесем в хэлперы?

@ssmike ssmike requested review from nepal and ulya-sidorina February 7, 2024 18:27
ulya-sidorina
ulya-sidorina previously approved these changes Feb 8, 2024
View reviewed changes
@ssmike ssmike enabled auto-merge (squash) February 8, 2024 10:37
nepal
nepal previously requested changes Feb 8, 2024
View reviewed changes
ydb/library/yql/core/yql_opt_utils.cpp Outdated
}

return usedFields.size() < inputStructType->GetSize();
return allowTrivial || usedFields.size() < inputStructType->GetSize();
Copy link
Collaborator

@nepal nepal Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему эту проверку нельзя в клиенте сделать?
HaveFieldSubset ведь заполнит usedFields

@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 11:48:14 UTC Pre-commit check for 4f7ea1c has started.
⚪ 2024-02-08 11:48:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 11:51:30 UTC Build successful.
⚪ 2024-02-08 11:51:39 UTC Tests are running...
🔴 2024-02-08 11:52:54 UTC Test run completed, no test results found for commit 616a026. Please check build logs.
⚫ 2024-02-08 11:52:56 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 11:49:14 UTC Pre-commit check for 4f7ea1c has started.
⚪ 2024-02-08 11:49:16 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-08 11:52:53 UTC Check cancelled

@ssmike ssmike force-pushed the delete-over-readranges branch from 616a026 to a9e4160 Compare February 8, 2024 11:52
@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 11:55:11 UTC Pre-commit check for 16848b1 has started.
⚪ 2024-02-08 11:55:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 11:57:04 UTC Build successful.
⚪ 2024-02-08 11:57:19 UTC Tests are running...
🔴 2024-02-08 12:09:58 UTC Test run completed, no test results found for commit a9e4160. Please check build logs.
⚫ 2024-02-08 12:10:01 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Feb 8, 2024 •
edited
Loading

⚪ 2024-02-08 11:56:28 UTC Pre-commit check for 16848b1 has started.
⚪ 2024-02-08 11:56:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 11:58:05 UTC Build successful.
⚪ 2024-02-08 11:58:14 UTC Tests are running...
🔴 2024-02-08 12:09:57 UTC Test run completed, no test results found for commit a9e4160. Please check build logs.
⚫ 2024-02-08 12:10:00 UTC Check cancelled

@ssmike ssmike force-pushed the delete-over-readranges branch from a9e4160 to 7398e96 Compare February 8, 2024 12:09
@ssmike ssmike merged commit ffc1355 into ydb-platform:main Feb 8, 2024
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 9, 2024
Merged
ssmike added a commit to ssmike/ydb that referenced this pull request Feb 9, 2024
@ssmike
Don't make lookups on predicate pushdown stage (ydb-platform#1560)
ef891ed 
Don't make lookups on predicate pushdown stage
@ssmike ssmike mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
@ssmike ssmike deleted the delete-over-readranges branch February 20, 2024 17:08
This was referenced Feb 21, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulya-sidorina ulya-sidorina ulya-sidorina approved these changes

@nepal nepal nepal left review comments

Assignees

@pavelvelikhov pavelvelikhov

@spuchin spuchin

@gridnevvvit gridnevvvit

@ulya-sidorina ulya-sidorina

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ssmike @nepal @ulya-sidorina @pavelvelikhov @spuchin @gridnevvvit