Dynamic listing mass fix by Hor911 · Pull Request #1913 · ydb-platform/ydb

Hor911 · 2024-02-14T10:33:54Z

Bugfix

github-actions · 2024-02-14T10:36:40Z

⚪ 2024-02-14 10:36:40 UTC Pre-commit check for f0ce60b has started.
⚪ 2024-02-14 10:36:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-14 10:42:57 UTC Build successful.
⚪ 2024-02-14 10:43:11 UTC Tests are running...
🔴 2024-02-14 10:45:35 UTC Test run completed, no test results found for commit b50b536. Please check build logs.
⚫ 2024-02-14 10:45:37 UTC Check cancelled

github-actions · 2024-02-14T10:36:45Z

⚪ 2024-02-14 10:36:45 UTC Pre-commit check for f0ce60b has started.
⚪ 2024-02-14 10:36:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-14 10:44:39 UTC Build successful.
⚪ 2024-02-14 10:44:51 UTC Tests are running...
🔴 2024-02-14 10:45:33 UTC Test run completed, no test results found for commit b50b536. Please check build logs.
⚫ 2024-02-14 10:45:35 UTC Check cancelled

github-actions · 2024-02-14T10:46:42Z

⚪ 2024-02-14 10:46:42 UTC Pre-commit check for b572e6e has started.
⚪ 2024-02-14 10:46:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-14 10:48:32 UTC Build successful.
⚪ 2024-02-14 10:48:39 UTC Tests are running...
🔴 2024-02-14 11:22:23 UTC Test run completed, no test results found for commit f9eefae. Please check build logs.
⚫ 2024-02-14 11:22:25 UTC Check cancelled

github-actions · 2024-02-14T10:54:18Z

⚪ 2024-02-14 10:54:18 UTC Pre-commit check for b572e6e has started.
⚪ 2024-02-14 10:54:19 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-14 10:56:51 UTC Build successful.
⚪ 2024-02-14 10:57:00 UTC Tests are running...
🔴 2024-02-14 11:22:29 UTC Test run completed, no test results found for commit f9eefae. Please check build logs.
⚫ 2024-02-14 11:22:33 UTC Check cancelled

github-actions · 2024-02-14T11:46:26Z

⚪ 2024-02-14 11:46:26 UTC Pre-commit check for 358f058 has started.
⚪ 2024-02-14 11:46:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-14 11:50:59 UTC Build successful.
⚪ 2024-02-14 11:51:08 UTC Tests are running...
🔴 2024-02-14 13:32:37 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67396	56441	0	17	10901	37

github-actions · 2024-02-14T11:47:00Z

⚪ 2024-02-14 11:46:59 UTC Pre-commit check for 358f058 has started.
⚪ 2024-02-14 11:47:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-14 11:52:49 UTC Build successful.
⚪ 2024-02-14 11:52:59 UTC Tests are running...
🔴 2024-02-14 13:31:18 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14766	14635	0	20	74	37

ydb/core/kqp/query_compiler/kqp_query_compiler.cpp

ydb/core/fq/libs/checkpointing/checkpoint_coordinator.cpp

github-actions · 2024-02-19T11:23:44Z

⚪ 2024-02-19 11:23:44 UTC Pre-commit check for 5905039 has started.
⚪ 2024-02-19 11:23:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-19 11:31:30 UTC Build successful.
⚪ 2024-02-19 11:31:40 UTC Tests are running...
🔴 2024-02-19 13:17:45 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14775	14633	0	23	93	26

github-actions · 2024-02-19T11:24:21Z

⚪ 2024-02-19 11:24:20 UTC Pre-commit check for 5905039 has started.
⚪ 2024-02-19 11:24:22 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-19 11:31:12 UTC Build successful.
⚪ 2024-02-19 11:31:25 UTC Tests are running...
🔴 2024-02-19 13:23:36 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67570	56571	0	9	10924	66

uzhastik · 2024-02-19T12:23:27Z

ydb/library/yql/providers/s3/actors/yql_s3_read_actor.cpp

        hFunc(TEvPrivate::TEvContinue, Handle);
        hFunc(TEvPrivate::TEvReadResult2, Handle);
        hFunc(NActors::TEvents::TEvPoison, Handle);
+        , catch (const std::exception& e) {


что за страшный синтаксис? нельзя обернуть свитч в try/catch ?

Так делают, но красивше не становится. Потому что весь сложный заголовок StateFunc вылезает из под макроса и еще по мелочи

github-actions · 2024-02-21T09:43:45Z

⚪ 2024-02-21 09:43:45 UTC Pre-commit check for 69932d8 has started.
⚪ 2024-02-21 09:43:47 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-21 09:51:25 UTC Build failed. see the build logs.
⚪ 2024-02-21 09:51:42 UTC Tests are running...
🔴 2024-02-21 10:15:53 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
36680	28778	0	294	7596	12

github-actions · 2024-02-21T09:46:16Z

⚪ 2024-02-21 09:46:16 UTC Pre-commit check for 69932d8 has started.
⚪ 2024-02-21 09:46:19 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-21 09:53:15 UTC Build failed. see the build logs.
⚪ 2024-02-21 09:53:27 UTC Tests are running...
🔴 2024-02-21 10:03:49 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
6079	5809	0	258	2	10

github-actions · 2024-02-21T14:39:23Z

⚪ 2024-02-21 14:39:22 UTC Pre-commit check for 0674201 has started.
⚪ 2024-02-21 14:39:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-21 14:44:45 UTC Build successful.
⚪ 2024-02-21 14:44:55 UTC Tests are running...
🔴 2024-02-21 16:23:24 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14820	14673	0	24	96	27

github-actions · 2024-02-21T14:39:39Z

⚪ 2024-02-21 14:39:39 UTC Pre-commit check for 0674201 has started.
⚪ 2024-02-21 14:39:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-21 14:44:40 UTC Build successful.
⚪ 2024-02-21 14:44:54 UTC Tests are running...
🔴 2024-02-21 16:34:38 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67800	56890	0	3	10883	24

Hor911 requested review from a team as code owners February 14, 2024 10:33

github-actions bot added the bugfix label Feb 14, 2024

uzhastik reviewed Feb 14, 2024

View reviewed changes

ydb/core/kqp/query_compiler/kqp_query_compiler.cpp Outdated Show resolved Hide resolved

uzhastik reviewed Feb 14, 2024

View reviewed changes

ydb/core/fq/libs/checkpointing/checkpoint_coordinator.cpp Show resolved Hide resolved

Hor911 force-pushed the YQ-2634-2 branch from 2dd9c05 to d9a42c8 Compare February 19, 2024 11:20

uzhastik reviewed Feb 19, 2024

View reviewed changes

Hor911 added 6 commits February 21, 2024 09:39

Dynamic listing mass fix

292f769

Rename HasPendingEvents()

d6775ca

Handle Undelivered

619d214

Handle Undelivered 2

80c6099

Better v1 support

012caf5

Handle exceptions in listing callback

be50758

Hor911 force-pushed the YQ-2634-2 branch from 0215bed to be50758 Compare February 21, 2024 09:40

Fix pointer vs ref

b2566f9

uzhastik approved these changes Feb 22, 2024

View reviewed changes

resetius approved these changes Feb 26, 2024

View reviewed changes

Hor911 merged commit 35f59b7 into ydb-platform:main Feb 26, 2024

shnikd mentioned this pull request Feb 27, 2024

Copy table with sequences and backup without NextVal #2285

Merged

serbel324 mentioned this pull request Mar 1, 2024

Mute OperationLog.ConcurrentWrites test #2381

Merged

Hor911 added a commit to Hor911/ydb that referenced this pull request Mar 3, 2024

Dynamic listing mass fix (ydb-platform#1913)

61bc57b

This was referenced Mar 4, 2024

YDB 647 add media type field #2405

Closed

YDB-647 add media type field #2441

Merged

GrigoriyPA mentioned this pull request Mar 7, 2024

YQ-2737 add TOKEN auth for YT datasource #2561

Merged

This was referenced Mar 8, 2024

HC made storage issue RED when no bsc reply #2578

Merged

time difference lines2 #2599

Closed

This was referenced Mar 11, 2024

Mute TImportTests.CancelUponCreatingTableShouldSucceed #2609

Merged

Fix TImportTests.CancelUponCreatingTableShouldSucceed #2636

Merged

Support CopySequence in schemeshard #2693

Merged

This was referenced Mar 13, 2024

YQ-2957 fix error in s3 stream read actor #2702

Merged

Fixed error due to empty token #2966

Merged

This was referenced Mar 20, 2024

Test alter temp table #3011

Merged

Support sequences backup with current value #3023

Closed

Support sequences backup with current value #3089

Merged

YDBDOCS-632: Documentation of temporary tables #3137

Merged

GrigoriyPA mentioned this pull request Mar 26, 2024

YQ-2738 add integration tests for YT in KQP #3150

Merged

shnikd mentioned this pull request Mar 26, 2024

Test temp indexes #3163

Merged

shnikd mentioned this pull request Apr 4, 2024

Support create sequence in pg parser #3465

Merged

EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 5, 2024

Dynamic listing mass fix (ydb-platform#1913)

48199c7

EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 8, 2024

Dynamic listing mass fix (ydb-platform#1913)

a19791f

Conversation

Hor911 commented Feb 14, 2024

Uh oh!

github-actions bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uzhastik Feb 19, 2024

Choose a reason for hiding this comment

Uh oh!

Hor911 Feb 21, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading