Skip to content

Extract ydb init to separate classes#2064

Merged
Enjection merged 21 commits intoydb-platform:mainfrom
Enjection:feature/KIKIMR-21044/extract-init-from-driver-lib-0
Feb 28, 2024
Merged

Extract ydb init to separate classes#2064
Enjection merged 21 commits intoydb-platform:mainfrom
Enjection:feature/KIKIMR-21044/extract-init-from-driver-lib-0

Conversation

@Enjection
Copy link
Copy Markdown
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2024

2024-02-19 13:13:14 UTC Pre-commit check for 273e9c4 has started.
2024-02-19 13:13:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-19 13:15:23 UTC Build successful.
2024-02-19 13:15:33 UTC Tests are running...
🔴 2024-02-19 15:13:03 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66857 54088 0 1666 10932 171

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2024

2024-02-19 13:18:10 UTC Pre-commit check for 273e9c4 has started.
2024-02-19 13:18:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-19 13:20:31 UTC Build successful.
2024-02-19 13:20:43 UTC Tests are running...
🔴 2024-02-19 15:34:06 UTC Test run completed, no test results found for commit b19f014. Please check build logs.
2024-02-19 15:34:08 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2024

2024-02-19 15:59:23 UTC Pre-commit check for 6806a98 has started.
2024-02-19 15:59:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-19 16:02:09 UTC Build successful.
2024-02-19 16:02:21 UTC Tests are running...
🔴 2024-02-19 18:15:39 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67078 54354 0 1660 10894 170

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2024

2024-02-19 16:04:41 UTC Pre-commit check for 6806a98 has started.
2024-02-19 16:04:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-19 16:06:43 UTC Build successful.
2024-02-19 16:06:52 UTC Tests are running...
🔴 2024-02-19 19:00:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14080 12253 0 1381 292 154

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2024

2024-02-19 19:32:25 UTC Pre-commit check for 4aef92d has started.
2024-02-19 19:32:27 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-19 19:34:47 UTC Build successful.
2024-02-19 19:34:59 UTC Tests are running...
🔴 2024-02-19 22:28:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13994 12127 0 1393 317 157

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2024

2024-02-19 19:32:29 UTC Pre-commit check for 4aef92d has started.
2024-02-19 19:32:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-19 19:34:41 UTC Build successful.
2024-02-19 19:34:57 UTC Tests are running...
🔴 2024-02-19 21:38:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66997 54239 0 1670 10915 173

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 09:25:05 UTC Pre-commit check for 4545a06 has started.
2024-02-20 09:25:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 09:27:16 UTC Build successful.
2024-02-20 09:27:33 UTC Tests are running...
🔴 2024-02-20 09:55:00 UTC Test run completed, no test results found for commit de2b9ec. Please check build logs.
2024-02-20 09:55:05 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 09:25:12 UTC Pre-commit check for 4545a06 has started.
2024-02-20 09:25:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 09:27:28 UTC Build successful.
2024-02-20 09:27:40 UTC Tests are running...
🔴 2024-02-20 09:54:59 UTC Test run completed, no test results found for commit de2b9ec. Please check build logs.
2024-02-20 09:55:02 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 09:56:22 UTC Pre-commit check for c8b9005 has started.
2024-02-20 09:56:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 09:58:23 UTC Build successful.
2024-02-20 09:58:35 UTC Tests are running...
🔴 2024-02-20 10:12:43 UTC Test run completed, no test results found for commit dbca8cf. Please check build logs.
2024-02-20 10:12:48 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 09:56:30 UTC Pre-commit check for c8b9005 has started.
2024-02-20 09:56:32 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 09:58:45 UTC Build successful.
2024-02-20 09:58:53 UTC Tests are running...
🔴 2024-02-20 10:12:28 UTC Test run completed, no test results found for commit dbca8cf. Please check build logs.
2024-02-20 10:12:32 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 10:14:03 UTC Pre-commit check for 9ddf2ff has started.
2024-02-20 10:14:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 10:53:23 UTC Build successful.
2024-02-20 10:53:33 UTC Tests are running...
🔴 2024-02-20 10:55:25 UTC Test run completed, no test results found for commit 2b45906. Please check build logs.
2024-02-20 10:55:28 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 10:16:38 UTC Pre-commit check for 9ddf2ff has started.
2024-02-20 10:16:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 10:51:51 UTC Build successful.
2024-02-20 10:52:05 UTC Tests are running...
🔴 2024-02-20 10:55:26 UTC Test run completed, no test results found for commit 2b45906. Please check build logs.
2024-02-20 10:55:29 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 10:57:35 UTC Pre-commit check for 3f1b7ad has started.
2024-02-20 10:57:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 10:59:36 UTC Build successful.
2024-02-20 10:59:44 UTC Tests are running...
🔴 2024-02-20 13:14:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67006 54247 0 1670 10915 174

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 10:57:46 UTC Pre-commit check for 3f1b7ad has started.
2024-02-20 10:57:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 10:59:25 UTC Build successful.
2024-02-20 10:59:37 UTC Tests are running...
🔴 2024-02-20 14:00:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14007 12131 0 1398 321 157

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 16:13:59 UTC Pre-commit check for cfab264 has started.
2024-02-20 16:14:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 16:41:14 UTC Build successful.
2024-02-20 16:41:28 UTC Tests are running...
🔴 2024-02-20 17:36:41 UTC Test run completed, no test results found for commit 0f04b8a. Please check build logs.
2024-02-20 17:36:44 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 16:15:52 UTC Pre-commit check for cfab264 has started.
2024-02-20 16:15:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 16:42:25 UTC Build successful.
2024-02-20 16:42:35 UTC Tests are running...
🔴 2024-02-20 17:36:41 UTC Test run completed, no test results found for commit 0f04b8a. Please check build logs.
2024-02-20 17:36:44 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 17:37:54 UTC Pre-commit check for 7ce66da has started.
2024-02-20 17:37:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 17:39:27 UTC Build successful.
2024-02-20 17:39:45 UTC Tests are running...
🔴 2024-02-20 17:58:22 UTC Test run completed, no test results found for commit ce282a8. Please check build logs.
2024-02-20 17:58:25 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 17:37:56 UTC Pre-commit check for 7ce66da has started.
2024-02-20 17:37:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 17:39:30 UTC Build successful.
2024-02-20 17:39:42 UTC Tests are running...
🔴 2024-02-20 17:58:12 UTC Test run completed, no test results found for commit ce282a8. Please check build logs.
2024-02-20 17:58:15 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 17:59:39 UTC Pre-commit check for 99960a6 has started.
2024-02-20 17:59:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 18:01:15 UTC Build successful.
2024-02-20 18:01:28 UTC Tests are running...
🔴 2024-02-20 18:45:15 UTC Test run completed, no test results found for commit 13b3706. Please check build logs.
2024-02-20 18:45:17 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 18:01:51 UTC Pre-commit check for 99960a6 has started.
2024-02-20 18:01:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 18:03:46 UTC Build successful.
2024-02-20 18:04:01 UTC Tests are running...
🔴 2024-02-20 18:45:15 UTC Test run completed, no test results found for commit 13b3706. Please check build logs.
2024-02-20 18:45:18 UTC Check cancelled

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 18:46:30 UTC Pre-commit check for 29e1325 has started.
2024-02-20 18:46:32 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 18:50:54 UTC Build successful.
2024-02-20 18:51:07 UTC Tests are running...
🔴 2024-02-20 21:07:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67011 54252 0 1670 10915 174

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2024

2024-02-20 18:47:12 UTC Pre-commit check for 29e1325 has started.
2024-02-20 18:47:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 18:51:19 UTC Build successful.
2024-02-20 18:51:28 UTC Tests are running...
🔴 2024-02-20 21:47:28 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14006 12139 0 1392 316 159

@Enjection Enjection requested a review from CyberROFL February 20, 2024 18:49
Copy link
Copy Markdown
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Каждый конфиг/опцию не валидировал, случайно просмотрел несколько — выглядит адекватно.


class IEnv {
public:
virtual ~IEnv() {}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если написать = default;, то оно ещё и смотреться будет единообразно с = 0; :)

std::unique_ptr<IDynConfigClient> MakeDefaultDynConfigClient();

std::unique_ptr<IInitialConfigurator> MakeDefaultInitialConfigurator(
NConfig::IErrorCollector& errorCollector,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При добавлении нового провайдера неприкольно будет добавлять новый аргумент функции. Может сразу структуру передавать?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2024

2024-02-26 09:31:25 UTC Pre-commit check for de4bb9e has started.
2024-02-26 09:31:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-26 09:38:56 UTC Build successful.
2024-02-26 09:39:08 UTC Tests are running...
🔴 2024-02-26 11:28:10 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61896 48964 0 1843 10925 164

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2024

2024-02-26 09:31:52 UTC Pre-commit check for de4bb9e has started.
2024-02-26 09:31:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-26 09:43:32 UTC Build successful.
2024-02-26 09:43:45 UTC Tests are running...
🔴 2024-02-26 12:05:20 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8844 6851 0 1550 295 148

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2024

2024-02-26 09:33:15 UTC Pre-commit check for de4bb9e has started.
2024-02-26 09:33:17 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-26 10:10:07 UTC Build successful.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2024

2024-02-26 14:37:28 UTC Pre-commit check for c612a6b has started.
2024-02-26 14:37:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-26 14:39:55 UTC Build successful.
2024-02-26 14:40:09 UTC Tests are running...
🔴 2024-02-26 16:06:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62575 51477 0 197 10885 16

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 26, 2024

2024-02-26 14:37:28 UTC Pre-commit check for c612a6b has started.
2024-02-26 14:37:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-26 14:39:54 UTC Build successful.
2024-02-26 14:40:08 UTC Tests are running...
🔴 2024-02-26 15:46:40 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9507 9228 0 197 66 16

@Enjection Enjection force-pushed the feature/KIKIMR-21044/extract-init-from-driver-lib-0 branch from 3f8344e to 06b8b32 Compare February 28, 2024 08:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 28, 2024

2024-02-28 08:16:02 UTC Pre-commit check for be293cc has started.
2024-02-28 08:16:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-28 08:18:24 UTC Build successful.
2024-02-28 08:18:40 UTC Tests are running...
🔴 2024-02-28 09:33:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67978 57067 0 10 10883 18

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 28, 2024

2024-02-28 08:16:09 UTC Pre-commit check for be293cc has started.
2024-02-28 08:16:12 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-28 08:18:33 UTC Build successful.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 28, 2024

2024-02-28 08:16:10 UTC Pre-commit check for be293cc has started.
2024-02-28 08:16:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-28 08:18:32 UTC Build successful.
2024-02-28 08:18:44 UTC Tests are running...
🔴 2024-02-28 09:57:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14876 14751 0 24 80 21

@Enjection Enjection merged commit 3c0eb8e into ydb-platform:main Feb 28, 2024
@Enjection Enjection deleted the feature/KIKIMR-21044/extract-init-from-driver-lib-0 branch February 28, 2024 13:11
@shnikd shnikd mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants