Skip to content

Forbid external offset commits for MLP consumers#35136

Merged
ubyte merged 2 commits intoydb-platform:mainfrom
ubyte:deny-mlp-offset-commit-LOGBROKER-10304
Mar 1, 2026
Merged

Forbid external offset commits for MLP consumers#35136
ubyte merged 2 commits intoydb-platform:mainfrom
ubyte:deny-mlp-offset-commit-LOGBROKER-10304

Conversation

@ubyte
Copy link
Collaborator

@ubyte ubyte commented Feb 27, 2026

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

LOGBROKER-10304

@ydbot
Copy link
Collaborator

ydbot commented Feb 27, 2026

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

2026-02-27 16:00:43 UTC Pre-commit check linux-x86_64-release-asan for 47c53f1 has started.
2026-02-27 16:01:01 UTC Artifacts will be uploaded here
2026-02-27 16:03:14 UTC ya make is running...
2026-02-27 16:36:38 UTC Check cancelled

@github-actions
Copy link

🟢 2026-02-27 16:01:31 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

2026-02-27 16:02:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47c53f1 has started.

@ubyte ubyte added the rebase-and-check Rebase PR with the current base branch and check label Feb 27, 2026
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 27, 2026
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

2026-02-27 16:40:29 UTC Pre-commit check linux-x86_64-release-asan for 47c53f1 has started.
2026-02-27 16:40:47 UTC Artifacts will be uploaded here
2026-02-27 16:42:58 UTC ya make is running...
🟡 2026-02-27 17:52:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17303 17262 0 27 10 4

🟢 2026-02-27 17:52:47 UTC Build successful.
🟢 2026-02-27 17:53:18 UTC ydbd size 3.9 GiB changed* by +17.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c5cea53 merge: 47c53f1 diff diff %
ydbd size 4 219 447 936 Bytes 4 219 465 848 Bytes +17.5 KiB +0.000%
ydbd stripped size 1 578 534 080 Bytes 1 578 538 304 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

2026-02-27 16:40:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47c53f1 has started.
2026-02-27 16:41:02 UTC Artifacts will be uploaded here
2026-02-27 16:43:14 UTC ya make is running...
🟡 2026-02-27 18:51:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
46462 43003 0 4 3444 11

2026-02-27 18:51:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-02-27 18:54:19 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 160 0 0 0 3

🟢 2026-02-27 18:54:26 UTC Build successful.
🟢 2026-02-27 18:54:49 UTC ydbd size 2.4 GiB changed* by +10.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c5cea53 merge: 47c53f1 diff diff %
ydbd size 2 589 200 288 Bytes 2 589 210 744 Bytes +10.2 KiB +0.000%
ydbd stripped size 545 241 768 Bytes 545 243 368 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ubyte ubyte marked this pull request as ready for review February 27, 2026 17:16
@ubyte ubyte merged commit f133fb8 into ydb-platform:main Mar 1, 2026
13 of 16 checks passed
@ubyte ubyte deleted the deny-mlp-offset-commit-LOGBROKER-10304 branch March 1, 2026 21:39
@ydbot
Copy link
Collaborator

ydbot commented Mar 1, 2026

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-4, stable-25-4-1, stable-26-1, stable-26-1-1 ▶  Backport
stable-26-1, stable-26-1-1 ▶  Backport
stable-26-1 ▶  Backport

▶  Backport manual

nshestakov pushed a commit to nshestakov/ydb that referenced this pull request Mar 3, 2026
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants