Skip to content

pq_composite: fix potential verify failure#35469

Merged
yumkam merged 3 commits intoydb-platform:mainfrom
yumkam:fix-composite-session-loosing-parition
Mar 5, 2026
Merged

pq_composite: fix potential verify failure#35469
yumkam merged 3 commits intoydb-platform:mainfrom
yumkam:fix-composite-session-loosing-parition

Conversation

@yumkam
Copy link
Collaborator

@yumkam yumkam commented Mar 5, 2026 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

IsReady() result may change from false to true and re-insert into Ready* -> either Y_VALIDATE failure, or would lead to loosing partition

@yumkam yumkam requested a review from GrigoriyPA March 5, 2026 00:59
@ydbot
Copy link
Collaborator

ydbot commented Mar 5, 2026

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶ Run tests

@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

⚪ 2026-03-05 01:26:30 UTC Pre-commit check linux-x86_64-release-asan for 3fe73e3 has started.
⚪ 2026-03-05 01:26:48 UTC Artifacts will be uploaded here
⚪ 2026-03-05 01:28:59 UTC ya make is running...
🟡 2026-03-05 02:48:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16965 16928 0 27 8 2

🟢 2026-03-05 02:48:20 UTC Build successful.
🟢 2026-03-05 02:48:50 UTC ydbd size 3.9 GiB changed* by -22.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5e6237b merge: 3fe73e3 diff diff %
ydbd size 4 220 693 216 Bytes 4 197 538 864 Bytes -22.1 MiB -0.549%
ydbd stripped size 1 578 922 112 Bytes 1 567 673 792 Bytes -10.7 MiB -0.712%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

Run-tests started

  • Build Preset: release-msan
  • Test Size: small,medium,large
  • Test Targets: ydb/library/yql/providers/pq/gateway/ut
  • Commit: 3fe73e3
  • Workflow run: link

⚪ 2026-03-05 05:20:02 UTC Artifacts will be uploaded here
⚪ 2026-03-05 05:21:23 UTC ya make is running...
🟢 2026-03-05 05:22:51 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1910 1878 0 0 31 1

🟢 2026-03-05 05:22:56 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

Run-tests started

  • Build Preset: release-tsan
  • Test Size: small,medium,large
  • Test Targets: ydb/library/yql/providers/pq/gateway/ut
  • Commit: 3fe73e3
  • Workflow run: link

⚪ 2026-03-05 05:53:48 UTC Artifacts will be uploaded here
⚪ 2026-03-05 05:55:06 UTC ya make is running...
🟡 2026-03-05 05:56:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1910 1870 0 8 31 1

⚪ 2026-03-05 05:56:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2026-03-05 05:57:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10 (only retried tests) 2 0 7 0 1

⚪ 2026-03-05 05:57:37 UTC ya make is running... (failed tests rerun, try 3)
🟡 2026-03-05 05:58:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 (only retried tests) 1 0 7 0 1

🟢 2026-03-05 05:58:19 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

⚪ 2026-03-05 04:34:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3fe73e3 has started.
⚪ 2026-03-05 04:35:08 UTC Artifacts will be uploaded here
⚪ 2026-03-05 04:37:18 UTC ya make is running...
🟢 2026-03-05 06:40:31 UTC ydbd size 2.4 GiB changed* by -12.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5e6237b merge: 3fe73e3 diff diff %
ydbd size 2 589 956 888 Bytes 2 576 986 960 Bytes -12.4 MiB -0.501%
ydbd stripped size 545 364 424 Bytes 541 856 136 Bytes -3.3 MiB -0.643%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2026-03-05 06:40:32 UTC Check cancelled

@yumkam yumkam changed the title Fix composite session loosing parition pq_composite: fix potential verify failure Mar 5, 2026
@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

Run-tests started

  • Build Preset: release-tsan
  • Test Size: small,medium,large
  • Test Targets: ydb/library/yql/providers/pq/gateway/ut
  • Commit: e0a4334
  • Workflow run: link

⚪ 2026-03-05 07:00:10 UTC Artifacts will be uploaded here
⚪ 2026-03-05 07:01:09 UTC ya make is running...
🟡 2026-03-05 07:31:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1910 1871 0 7 31 1

⚪ 2026-03-05 07:31:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2026-03-05 07:32:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Details

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 (only retried tests) 1 0 7 0 1

⚪ 2026-03-05 07:32:40 UTC ya make is running... (failed tests rerun, try 3)
🟡 2026-03-05 07:33:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 (only retried tests) 1 0 7 0 1

🟢 2026-03-05 07:33:25 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

Run-tests started

  • Build Preset: release-msan
  • Test Size: small,medium,large
  • Test Targets: ydb/library/yql/providers/pq/gateway/ut
  • Commit: e0a4334
  • Workflow run: link

⚪ 2026-03-05 07:37:29 UTC Artifacts will be uploaded here
⚪ 2026-03-05 07:38:52 UTC ya make is running...
🟢 2026-03-05 08:11:13 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1910 1879 0 0 31 0

🟢 2026-03-05 08:11:19 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

⚪ 2026-03-05 06:51:42 UTC Pre-commit check linux-x86_64-release-asan for e0a4334 has started.
⚪ 2026-03-05 06:53:04 UTC Artifacts will be uploaded here
⚪ 2026-03-05 06:55:13 UTC ya make is running...
🟡 2026-03-05 08:24:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16965 16900 0 53 7 5

🟢 2026-03-05 08:24:41 UTC Build successful.
🟢 2026-03-05 08:25:10 UTC ydbd size 3.9 GiB changed* by -22.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5e6237b merge: e0a4334 diff diff %
ydbd size 4 220 693 216 Bytes 4 197 218 008 Bytes -22.4 MiB -0.556%
ydbd stripped size 1 578 922 112 Bytes 1 568 131 840 Bytes -10.3 MiB -0.683%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as ready for review March 5, 2026 06:56
@yumkam yumkam requested a review from a team as a code owner March 5, 2026 06:56
Copilot AI review requested due to automatic review settings March 5, 2026 06:56
Copilot AI reviewed Mar 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts partition-session redistribution order in the PQ composite read session to avoid a potential Y_VALIDATE failure when a partition’s readiness changes between checks.

Changes:

  • Remove the current partition from ReadyPartitions before redistributing it into Pending/Idle/Ready sets.
  • Prevent a possible re-emplace into ReadyPartitions while the key is still present there.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026 •
edited
Loading

⚪ 2026-03-05 07:13:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for e0a4334 has started.
⚪ 2026-03-05 07:15:29 UTC Artifacts will be uploaded here
⚪ 2026-03-05 07:17:32 UTC ya make is running...
🟡 2026-03-05 09:08:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45867 42416 0 6 3436 9

⚪ 2026-03-05 09:08:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2026-03-05 09:13:34 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
359 (only retried tests) 358 0 0 0 1

🟢 2026-03-05 09:13:38 UTC Build successful.
🟢 2026-03-05 09:14:07 UTC ydbd size 2.4 GiB changed* by -13.0 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5e6237b merge: e0a4334 diff diff %
ydbd size 2 589 956 888 Bytes 2 576 325 656 Bytes -13.0 MiB -0.526%
ydbd stripped size 545 364 424 Bytes 541 965 608 Bytes -3.2 MiB -0.623%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam merged commit 9372246 into ydb-platform:main Mar 5, 2026
16 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Mar 5, 2026

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-4, stable-25-4-1, stable-26-1, stable-26-1-1 ▶ Backport
stable-26-1, stable-26-1-1 ▶ Backport
stable-26-1 ▶ Backport

▶ Backport manual

@ydbot
Copy link
Collaborator

ydbot commented Mar 5, 2026 •
edited
Loading

Backport results:

workflow run

ydbot pushed a commit that referenced this pull request Mar 5, 2026
@yumkam @ydbot
pq_composite: fix potential verify failure (#35469)
6094a85
@ydbot ydbot mentioned this pull request Mar 5, 2026
Merged
ydbot pushed a commit that referenced this pull request Mar 5, 2026
@yumkam @ydbot
pq_composite: fix potential verify failure (#35469)
9f255c2
@ydbot ydbot mentioned this pull request Mar 5, 2026
Merged
ydbot added a commit that referenced this pull request Mar 5, 2026
@ydbot
[Backport stable-26-1] PR #35469: pq_composite: fix potential verify …
27451c1 
…failure (#35487)
ydbot added a commit that referenced this pull request Mar 5, 2026
@ydbot
[Backport stable-26-1-1] PR #35469: pq_composite: fix potential verif…
b20c4ca 
…y failure (#35488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@GrigoriyPA GrigoriyPA GrigoriyPA approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yumkam @ydbot @GrigoriyPA