Skip to content

YQL-18386 reduced number of files created while spilling WideCombiner #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lll-phill-lll merged 1 commit into from
May 21, 2024
Merged

YQL-18386 reduced number of files created while spilling WideCombiner #4711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,24 +675,27 @@ class TSpillingSupportState : public TComputationValue<TSpillingSupportState> {

void SwitchMode(EOperatingMode mode, TComputationContext& ctx) {
switch(mode) {
case EOperatingMode::InMemory:
case EOperatingMode::InMemory: {
MKQL_ENSURE(false, "Internal logic error");
break;
case EOperatingMode::Spilling:
}
case EOperatingMode::Spilling: {
MKQL_ENSURE(EOperatingMode::InMemory == Mode, "Internal logic error");
SpilledBuckets.resize(SpilledBucketCount);
auto spiller = ctx.SpillerFactory->CreateSpiller();
for (auto &b: SpilledBuckets) {
auto spiller = ctx.SpillerFactory->CreateSpiller();
b.SpilledState = std::make_unique<TWideUnboxedValuesSpillerAdapter>(spiller, KeyAndStateType, 5_MB);
b.SpilledData = std::make_unique<TWideUnboxedValuesSpillerAdapter>(spiller, UsedInputItemType, 5_MB);
b.InMemoryProcessingState = std::make_unique<TState>(MemInfo, KeyWidth, KeyAndStateType->GetElementsCount() - KeyWidth, Hasher, Equal);
}
SplitStateIntoBuckets();
break;
case EOperatingMode::ProcessSpilled:
}
case EOperatingMode::ProcessSpilled: {
MKQL_ENSURE(EOperatingMode::Spilling == Mode, "Internal logic error");
MKQL_ENSURE(SpilledBuckets.size() == SpilledBucketCount, "Internal logic error");
break;
}

}
Mode = mode;
Expand Down