Skip to content

Fix ReadLogContinue race on stop#4791

Merged
alexvru merged 1 commit intoydb-platform:mainfrom
alexvru:pdisk/fix-read-log-continue
May 23, 2024
Merged

Fix ReadLogContinue race on stop#4791
alexvru merged 1 commit intoydb-platform:mainfrom
alexvru:pdisk/fix-read-log-continue

Conversation

@alexvru
Copy link
Copy Markdown
Collaborator

@alexvru alexvru commented May 23, 2024

Changelog entry

Fix ReadLogContinue race on stop

Changelog category

  • Bugfix

Additional information

Plain pointer was replaced by shared/weak pointer.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 23, 2024

2024-05-23 15:39:57 UTC Pre-commit check for bfe2b2e has started.
2024-05-23 15:42:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 15:44:59 UTC Build successful.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 23, 2024

2024-05-23 15:39:58 UTC Pre-commit check for bfe2b2e has started.
2024-05-23 15:42:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 15:44:52 UTC Build successful.
2024-05-23 15:45:05 UTC Tests are running...
🔴 2024-05-23 17:46:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9980 9909 0 34 26 11

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 23, 2024

2024-05-23 15:40:19 UTC Pre-commit check for bfe2b2e has started.
2024-05-23 15:42:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 15:45:03 UTC Build successful.
2024-05-23 15:45:17 UTC Tests are running...
🔴 2024-05-23 17:06:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14099 12792 0 1 1299 7

@alexvru alexvru enabled auto-merge (squash) May 23, 2024 18:20
Copy link
Copy Markdown
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexvru alexvru merged commit 95371ef into ydb-platform:main May 23, 2024
@alexvru alexvru deleted the pdisk/fix-read-log-continue branch May 23, 2024 18:36
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants