Skip to content

Add 'constraints' to s3 bindings #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
resetius merged 1 commit into from
May 24, 2024
Merged

Add 'constraints' to s3 bindings #4849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ydb/library/yql/providers/s3/provider/yql_s3_datasource_type_ann.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,14 @@ class TS3DataSourceTypeAnnotationTransformer : public TVisitorTransformerBase {
return true;
}

if (name == "constraints"sv) {
TStringBuf unused;
if (!ExtractSettingValue(setting.Tail(), "constraints"sv, format, {}, ctx, unused)) {
return false;
}
return true;
}

YQL_ENSURE(name == "projection"sv);
haveProjection = true;
if (!EnsureAtom(setting.Tail(), ctx)) {
Expand All @@ -721,7 +729,7 @@ class TS3DataSourceTypeAnnotationTransformer : public TVisitorTransformerBase {
return true;
};
if (!EnsureValidSettings(*input->Child(TS3Object::idx_Settings),
{ "compression"sv, "partitionedby"sv, "projection"sv, "data.interval.unit"sv,
{ "compression"sv, "partitionedby"sv, "projection"sv, "data.interval.unit"sv, "constraints"sv,
"data.datetime.formatname"sv, "data.datetime.format"sv, "data.timestamp.formatname"sv, "data.timestamp.format"sv,
"readmaxbytes"sv, "csvdelimiter"sv, "directories"sv, "filepattern"sv, "pathpattern"sv, "pathpatternvariant"sv }, validator, ctx))
{
Expand Down
2 changes: 2 additions & 0 deletions ydb/library/yql/utils/bindings/utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ void LoadBindings(THashMap<TString, NSQLTranslation::TTableBindingSettings>& dst
binding.ClusterType = v.GetString();
} else if (k == "schema") {
binding.Settings["schema"] = SerializeJsonValueAsYsonText(v);
} else if (k == "constraints") {
binding.Settings["constraints"] = SerializeJsonValueAsYsonText(v);
} else {
YQL_ENSURE(v.IsString());
binding.Settings.emplace(k, v.GetString());
Expand Down