Introduce DescribeReplication#4904
Conversation
CyberROFL
force-pushed
the
describe-replication
branch
from
522071d to
51eea7b
Compare
CyberROFL
force-pushed
the
describe-replication
branch
from
51eea7b to
ba161eb
Compare
CyberROFL
force-pushed
the
describe-replication
branch
from
ba161eb to
5c6d0c2
Compare
|
⚪ |
|
⚪
|
|
⚪
|
Enjection
left a comment
Enjection
left a comment
There was a problem hiding this comment.
Все коменты минорные в целом ОК
| void Handle(NSchemeShard::TEvSchemeShard::TEvDescribeSchemeResult::TPtr& ev, const TActorContext& ctx) { | ||
| const auto& record = ev->Get()->GetRecord(); | ||
| const auto& desc = record.GetPathDescription(); | ||
|
|
||
| if (record.HasReason()) { | ||
| auto issue = NYql::TIssue(record.GetReason()); | ||
| Request_->RaiseIssue(issue); | ||
| } | ||
|
|
||
| switch (record.GetStatus()) { | ||
| case NKikimrScheme::StatusSuccess: | ||
| if (desc.GetSelf().GetPathType() != NKikimrSchemeOp::EPathTypeReplication) { | ||
| auto issue = NYql::TIssue("Is not a replication"); | ||
| Request_->RaiseIssue(issue); | ||
| return Reply(Ydb::StatusIds::SCHEME_ERROR, ctx); | ||
| } | ||
|
|
||
| ConvertDirectoryEntry(desc.GetSelf(), Result.mutable_self(), true); | ||
| return DescribeReplication(desc.GetReplicationDescription().GetControllerId(), | ||
| PathIdFromPathId(desc.GetReplicationDescription().GetPathId())); | ||
|
|
||
| case NKikimrScheme::StatusPathDoesNotExist: | ||
| case NKikimrScheme::StatusSchemeError: | ||
| return Reply(Ydb::StatusIds::SCHEME_ERROR, ctx); | ||
|
|
||
| case NKikimrScheme::StatusAccessDenied: | ||
| return Reply(Ydb::StatusIds::UNAUTHORIZED, ctx); | ||
|
|
||
| case NKikimrScheme::StatusNotAvailable: | ||
| return Reply(Ydb::StatusIds::UNAVAILABLE, ctx); | ||
|
|
||
| default: { | ||
| return Reply(Ydb::StatusIds::GENERIC_ERROR, ctx); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Выглядит так, что мы таскаем эту копипасту из функции в функцию, в данном ревью не критично, но стоит обобщить.
| default: | ||
| break; |
There was a problem hiding this comment.
- default скроет ошибку компилятора при добавлении нового кейса
- отсутствует логирование на неизвестный кейс.
2 participants
Changelog entry
...
Changelog category
Additional information
...