non partitioned lister has been sped up by dorooleg · Pull Request #5870 · ydb-platform/ydb

dorooleg · 2024-06-24T08:30:59Z

Changelog entry

...

Changelog category

Performance improvement

Additional information

...

github-actions · 2024-06-24T08:34:32Z

⚪ 2024-06-24 08:34:32 UTC Pre-commit check for a2e64fc has started.
⚪ 2024-06-24 08:37:02 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-24 08:38:49 UTC Build successful.

github-actions · 2024-06-24T08:34:52Z

⚪ 2024-06-24 08:34:52 UTC Pre-commit check for a2e64fc has started.
⚪ 2024-06-24 08:37:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-24 08:39:00 UTC Build successful.
⚪ 2024-06-24 08:39:14 UTC Tests are running...
🔴 2024-06-24 10:38:05 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37796	32569	0	8	5209	10

🟢 2024-06-24 10:39:04 UTC ydbd size 8.3 GiB changed* by +464 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b89687a`	merge: `a2e64fc`	diff	diff %
ydbd size	8 962 573 320 Bytes	8 962 573 784 Bytes	+464 Bytes	+0.000%
ydbd stripped size	488 464 936 Bytes	488 465 000 Bytes	+64 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-24T08:35:13Z

⚪ 2024-06-24 08:35:13 UTC Pre-commit check for a2e64fc has started.
⚪ 2024-06-24 08:37:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-24 08:39:40 UTC Build successful.
⚪ 2024-06-24 08:39:53 UTC Tests are running...
🔴 2024-06-24 10:49:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9529	8926	0	100	334	169

🟢 2024-06-24 10:50:04 UTC ydbd size 5.5 GiB changed* by +144 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b89687a`	merge: `a2e64fc`	diff	diff %
ydbd size	5 855 555 136 Bytes	5 855 555 280 Bytes	+144 Bytes	+0.000%
ydbd stripped size	1 255 711 784 Bytes	1 255 712 040 Bytes	+256 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-25T21:13:36Z

⚪ 2024-06-25 21:13:36 UTC Pre-commit check for 6703d10 has started.
⚪ 2024-06-25 21:16:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-25 21:17:36 UTC Build successful.
⚪ 2024-06-25 21:17:49 UTC Tests are running...
🔴 2024-06-25 23:11:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37063	31890	0	3	5157	13

🟢 2024-06-25 23:12:19 UTC ydbd size 8.4 GiB changed* by -5.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `9910c50`	merge: `6703d10`	diff	diff %
ydbd size	9 004 302 080 Bytes	9 004 296 760 Bytes	-5.2 KiB	-0.000%
ydbd stripped size	491 729 000 Bytes	491 728 104 Bytes	-896 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-25T21:14:35Z

⚪ 2024-06-25 21:14:35 UTC Pre-commit check for 6703d10 has started.
⚪ 2024-06-25 21:17:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-25 21:18:46 UTC Build successful.

github-actions · 2024-06-25T21:15:58Z

⚪ 2024-06-25 21:15:58 UTC Pre-commit check for 6703d10 has started.
⚪ 2024-06-25 21:18:33 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-25 21:20:21 UTC Build successful.
⚪ 2024-06-25 21:20:36 UTC Tests are running...
🔴 2024-06-25 23:26:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9545	8954	0	86	335	170

🟢 2024-06-25 23:27:28 UTC ydbd size 5.5 GiB changed* by -27.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `9910c50`	merge: `6703d10`	diff	diff %
ydbd size	5 900 673 224 Bytes	5 900 644 784 Bytes	-27.8 KiB	-0.000%
ydbd stripped size	1 267 433 864 Bytes	1 267 421 704 Bytes	-11.9 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-26T07:35:12Z

⚪ 2024-06-26 07:35:12 UTC Pre-commit check for 85152e9 has started.
⚪ 2024-06-26 07:37:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 07:39:09 UTC Build successful.
⚪ 2024-06-26 07:39:24 UTC Tests are running...
🔴 2024-06-26 09:46:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9555	8975	0	85	327	168

🟢 2024-06-26 09:47:12 UTC ydbd size 5.5 GiB changed* by -17.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `9910c50`	merge: `85152e9`	diff	diff %
ydbd size	5 900 673 224 Bytes	5 900 654 984 Bytes	-17.8 KiB	-0.000%
ydbd stripped size	1 267 433 864 Bytes	1 267 422 920 Bytes	-10.7 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-26T07:35:13Z

⚪ 2024-06-26 07:35:12 UTC Pre-commit check for 85152e9 has started.
⚪ 2024-06-26 07:37:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 07:39:37 UTC Build successful.
⚪ 2024-06-26 07:39:49 UTC Tests are running...
🔴 2024-06-26 09:30:45 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37063	31886	0	3	5160	14

🟢 2024-06-26 09:31:25 UTC ydbd size 8.4 GiB changed* by +568 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `9910c50`	merge: `85152e9`	diff	diff %
ydbd size	9 004 302 080 Bytes	9 004 302 648 Bytes	+568 Bytes	+0.000%
ydbd stripped size	491 729 000 Bytes	491 728 616 Bytes	-384 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-26T07:35:22Z

⚪ 2024-06-26 07:35:22 UTC Pre-commit check for 85152e9 has started.
⚪ 2024-06-26 07:38:00 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-26 07:40:04 UTC Build successful.

uzhastik · 2024-06-26T16:29:43Z

    TPath::TFileTreeMap* currentChildren = &Roots;
    for (size_t i = 0, size = parts.size(); i < size; ++i) {
-        bool isSubDirectory = i != size - 1;
+        bool isSubDirectory = i != size - 1; 


лишний пробел добавил?

github-actions · 2024-06-26T17:10:38Z

⚪ 2024-06-26 17:10:38 UTC Pre-commit check for f4d6065 has started.
⚪ 2024-06-26 17:12:58 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-26 17:45:59 UTC Build successful.

github-actions · 2024-06-26T17:12:29Z

⚪ 2024-06-26 17:12:29 UTC Pre-commit check for f4d6065 has started.
⚪ 2024-06-26 17:14:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 17:46:36 UTC Build successful.
⚪ 2024-06-26 17:46:47 UTC Tests are running...
🔴 2024-06-26 19:33:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
37056	31869	0	1	5167	19

🟢 2024-06-26 19:33:56 UTC ydbd size 8.4 GiB changed* by +632 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `2fc2f71`	merge: `f4d6065`	diff	diff %
ydbd size	9 019 325 608 Bytes	9 019 326 240 Bytes	+632 Bytes	+0.000%
ydbd stripped size	492 617 000 Bytes	492 616 680 Bytes	-320 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-06-26T17:14:11Z

⚪ 2024-06-26 17:14:11 UTC Pre-commit check for f4d6065 has started.
⚪ 2024-06-26 17:16:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 17:37:56 UTC Build successful.
⚪ 2024-06-26 17:38:12 UTC Tests are running...
🔴 2024-06-26 19:35:35 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9557	8977	0	78	324	178

🟢 2024-06-26 19:36:19 UTC ydbd size 5.5 GiB changed* by -17.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `2fc2f71`	merge: `f4d6065`	diff	diff %
ydbd size	5 914 057 384 Bytes	5 914 039 152 Bytes	-17.8 KiB	-0.000%
ydbd stripped size	1 270 513 128 Bytes	1 270 502 184 Bytes	-10.7 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

non partitioned lister has been sped up

042597d

dorooleg requested a review from a team as a code owner June 24, 2024 08:30

github-actions Bot added the performance label Jun 24, 2024

UnpackPathsList has been fixed

a96fe73

one more time

92805a0

uzhastik reviewed Jun 26, 2024

View reviewed changes

cleanup

4632a3e

uzhastik approved these changes Jun 26, 2024

View reviewed changes

dorooleg merged commit 84a22eb into ydb-platform:main Jun 26, 2024

dorooleg added a commit to dorooleg/ydb that referenced this pull request Jun 27, 2024

non partitioned lister has been sped up (ydb-platform#5870)

d631bbb

dorooleg added a commit to dorooleg/ydb that referenced this pull request Jun 27, 2024

non partitioned lister has been sped up (ydb-platform#5870)

b065075

dorooleg added a commit that referenced this pull request Jun 27, 2024

non partitioned lister has been sped up (#5870) (#6002)

aea719a

dorooleg added a commit that referenced this pull request Jun 27, 2024

non partitioned lister has been sped up (#5870) (#6003)

8723696

niksaveliev mentioned this pull request Jul 1, 2024

Add few auto partitioning fields to describe and SDK. Add important consumer to CLI #6118

Merged

GrigoriyPA mentioned this pull request Jul 2, 2024

YYQ-3398 fixed result set size counting #6157

Merged

GrigoriyPA mentioned this pull request Jul 15, 2024

KqpRun sync stable version with main #6670

Closed

GrigoriyPA mentioned this pull request Sep 26, 2024

YQ-3684 fix screts not found error handling #9822

Closed

Conversation

dorooleg commented Jun 24, 2024

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions Bot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uzhastik Jun 26, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 24, 2024 •

edited

Loading

github-actions Bot commented Jun 24, 2024 •

edited

Loading

github-actions Bot commented Jun 24, 2024 •

edited

Loading

github-actions Bot commented Jun 25, 2024 •

edited

Loading

github-actions Bot commented Jun 25, 2024 •

edited

Loading

github-actions Bot commented Jun 25, 2024 •

edited

Loading

github-actions Bot commented Jun 26, 2024 •

edited

Loading

github-actions Bot commented Jun 26, 2024 •

edited

Loading

github-actions Bot commented Jun 26, 2024 •

edited

Loading

github-actions Bot commented Jun 26, 2024 •

edited

Loading

github-actions Bot commented Jun 26, 2024 •

edited

Loading

github-actions Bot commented Jun 26, 2024 •

edited

Loading