Skip to content

Fixed a problem in RBO in MapJoin implementation#7044

Merged
pavelvelikhov merged 9 commits intoydb-platform:mainfrom
pavelvelikhov:FixMapJoinCBO
Jul 26, 2024
Merged

Fixed a problem in RBO in MapJoin implementation#7044
pavelvelikhov merged 9 commits intoydb-platform:mainfrom
pavelvelikhov:FixMapJoinCBO

Conversation

@pavelvelikhov
Copy link
Collaborator

@pavelvelikhov pavelvelikhov commented Jul 24, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@pavelvelikhov pavelvelikhov requested review from a team as code owners July 24, 2024 12:34
@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:38:43 UTC Pre-commit check for aa9ffe3 has started.
⚪ 2024-07-24 12:41:52 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 14:46:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71594 57188 0 847 13547 12

🔴 2024-07-24 14:56:03 UTC Too many tests failed, NOT going to retry
🟢 2024-07-24 14:56:05 UTC Build successful.
🔴 2024-07-24 14:57:10 UTC ydbd size 8.1 GiB changed* by +2.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 48a86ec merge: aa9ffe3 diff diff %
ydbd size 8 652 588 944 Bytes 8 655 416 352 Bytes +2.7 MiB +0.033%
ydbd stripped size 471 059 072 Bytes 471 212 288 Bytes +149.6 KiB +0.033%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:38:48 UTC Pre-commit check for aa9ffe3 has started.
⚪ 2024-07-24 12:41:37 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 12:48:09 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 12:39:03 UTC Pre-commit check for aa9ffe3 has started.
⚪ 2024-07-24 12:42:07 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-24 14:51:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10228 9618 0 107 332 171

🟢 2024-07-24 14:52:45 UTC Build successful.
🟢 2024-07-24 14:53:32 UTC ydbd size 5.2 GiB changed* by -176 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1def359 merge: aa9ffe3 diff diff %
ydbd size 5 558 078 952 Bytes 5 558 078 776 Bytes -176 Bytes -0.000%
ydbd stripped size 1 197 262 512 Bytes 1 197 262 448 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 15:52:59 UTC Pre-commit check for f026416 has started.
⚪ 2024-07-24 15:55:49 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-24 16:28:19 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 15:53:04 UTC Pre-commit check for f026416 has started.
⚪ 2024-07-24 15:56:03 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 16:05:16 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 15:53:20 UTC Pre-commit check for f026416 has started.
⚪ 2024-07-24 15:56:14 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-24 16:28:41 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 20:25:47 UTC Pre-commit check for 214034c has started.
⚪ 2024-07-24 20:28:40 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-24 20:29:38 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 17:24:30 UTC Pre-commit check for 214034c has started.
⚪ 2024-07-24 17:27:25 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 18:09:33 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 20:25:53 UTC Pre-commit check for 214034c has started.
⚪ 2024-07-24 20:28:43 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-24 20:29:40 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 20:30:50 UTC Pre-commit check for 186a010 has started.
⚪ 2024-07-24 20:34:11 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-24 22:43:37 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10250 9649 0 94 333 174

🟢 2024-07-24 22:44:37 UTC Build successful.
🟢 2024-07-24 22:52:12 UTC ydbd size 5.2 GiB changed* by -240 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 906c936 merge: 186a010 diff diff %
ydbd size 5 559 787 584 Bytes 5 559 787 344 Bytes -240 Bytes -0.000%
ydbd stripped size 1 197 590 448 Bytes 1 197 590 320 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 20:33:32 UTC Pre-commit check for 186a010 has started.
⚪ 2024-07-24 20:36:32 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-24 20:43:25 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

⚪ 2024-07-24 20:33:38 UTC Pre-commit check for 186a010 has started.
⚪ 2024-07-24 20:36:39 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-24 22:51:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71605 58032 0 6 13547 20

⚪ 2024-07-24 22:58:30 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-24 23:06:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 5 0 6 0 8

⚪ 2024-07-24 23:12:39 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-24 23:20:43 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 1 0 6 0 8

🟢 2024-07-24 23:27:14 UTC Build successful.
🟢 2024-07-24 23:28:01 UTC ydbd size 8.1 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 906c936 merge: 186a010 diff diff %
ydbd size 8 659 252 792 Bytes 8 659 252 696 Bytes -96 Bytes -0.000%
ydbd stripped size 471 309 088 Bytes 471 309 152 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 05:24:34 UTC Pre-commit check for f972f73 has started.
⚪ 2024-07-26 05:27:34 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 07:32:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10254 9667 0 82 333 172

🟢 2024-07-26 07:33:26 UTC Build successful.
🟢 2024-07-26 07:34:22 UTC ydbd size 5.2 GiB changed* by -176 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 34b6297 merge: f972f73 diff diff %
ydbd size 5 564 663 224 Bytes 5 564 663 048 Bytes -176 Bytes -0.000%
ydbd stripped size 1 198 266 832 Bytes 1 198 266 768 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 05:27:20 UTC Pre-commit check for f972f73 has started.
⚪ 2024-07-26 05:30:02 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 05:36:38 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 05:37:54 UTC Pre-commit check for f972f73 has started.
⚪ 2024-07-26 05:40:38 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 07:49:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71607 58034 0 8 13547 18

⚪ 2024-07-26 07:56:55 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 08:04:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 9 0 5 0 8

⚪ 2024-07-26 08:11:37 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-26 08:19:36 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 1 0 5 0 8

🟢 2024-07-26 08:26:19 UTC Build successful.
🟢 2024-07-26 08:27:00 UTC ydbd size 8.1 GiB changed* by -144 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 34b6297 merge: f972f73 diff diff %
ydbd size 8 667 429 864 Bytes 8 667 429 720 Bytes -144 Bytes -0.000%
ydbd stripped size 471 525 696 Bytes 471 525 696 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 10:14:10 UTC Pre-commit check for c90cec9 has started.
⚪ 2024-07-26 10:17:21 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 10:23:04 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 10:17:39 UTC Pre-commit check for c90cec9 has started.
⚪ 2024-07-26 10:20:37 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 10:29:13 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 10:24:53 UTC Pre-commit check for c90cec9 has started.
⚪ 2024-07-26 10:27:53 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-26 10:28:46 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 10:32:51 UTC Pre-commit check for baee8d1 has started.
⚪ 2024-07-26 10:38:35 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 12:43:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71611 58046 0 6 13548 11

⚪ 2024-07-26 12:51:14 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 12:58:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 4 0 4 0 8

🟢 2024-07-26 13:05:21 UTC ydbd size 8.1 GiB changed* by +33.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6064125 merge: baee8d1 diff diff %
ydbd size 8 667 494 768 Bytes 8 667 528 608 Bytes +33.0 KiB +0.000%
ydbd stripped size 471 530 176 Bytes 471 532 576 Bytes +2.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-07-26 13:05:22 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 10:34:13 UTC Pre-commit check for baee8d1 has started.
⚪ 2024-07-26 10:37:26 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 10:42:56 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 10:36:09 UTC Pre-commit check for baee8d1 has started.
⚪ 2024-07-26 10:39:01 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 12:48:31 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10252 9657 0 83 337 175

🟢 2024-07-26 12:49:40 UTC Build successful.
🟢 2024-07-26 12:50:25 UTC ydbd size 5.2 GiB changed* by +49.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6064125 merge: baee8d1 diff diff %
ydbd size 5 564 723 528 Bytes 5 564 773 776 Bytes +49.1 KiB +0.001%
ydbd stripped size 1 198 281 584 Bytes 1 198 287 536 Bytes +5.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn
Copy link
Collaborator

vitstn commented Jul 26, 2024

сломаны результаты в dqfile

vitstn
vitstn reviewed Jul 26, 2024
View reviewed changes
vitstn
vitstn requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@vitstn vitstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 13:10:41 UTC Pre-commit check for c793b2f has started.
⚪ 2024-07-26 13:13:38 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 13:20:39 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 13:11:47 UTC Pre-commit check for c793b2f has started.
⚪ 2024-07-26 13:15:03 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-07-26 13:55:15 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 13:18:59 UTC Pre-commit check for c793b2f has started.
⚪ 2024-07-26 13:21:52 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 13:54:59 UTC Check cancelled

@pavelvelikhov pavelvelikhov requested a review from vitstn July 26, 2024 13:55
@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 13:56:33 UTC Pre-commit check for 2516dd7 has started.
⚪ 2024-07-26 13:59:45 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-26 14:01:42 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 14:03:41 UTC Pre-commit check for 1d1a949 has started.
⚪ 2024-07-26 14:07:04 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 16:18:09 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10258 9671 0 81 333 173

🟢 2024-07-26 16:19:13 UTC Build successful.
🟢 2024-07-26 16:20:05 UTC ydbd size 5.2 GiB changed* by +50.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f773909 merge: 1d1a949 diff diff %
ydbd size 5 565 447 976 Bytes 5 565 500 024 Bytes +50.8 KiB +0.001%
ydbd stripped size 1 198 385 072 Bytes 1 198 398 608 Bytes +13.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 14:05:21 UTC Pre-commit check for 1d1a949 has started.
⚪ 2024-07-26 14:08:13 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 14:35:44 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 14:05:30 UTC Pre-commit check for 1d1a949 has started.
⚪ 2024-07-26 14:08:25 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 16:29:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71613 58038 0 8 13549 18

⚪ 2024-07-26 16:37:57 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 16:46:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27 (only retried tests) 15 0 2 0 10

⚪ 2024-07-26 16:53:35 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-07-26 17:01:47 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 2 0 2 0 10

🟢 2024-07-26 17:08:37 UTC Build successful.
🟢 2024-07-26 17:09:20 UTC ydbd size 8.1 GiB changed* by +20.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cf53155 merge: 1d1a949 diff diff %
ydbd size 8 668 656 352 Bytes 8 668 677 616 Bytes +20.8 KiB +0.000%
ydbd stripped size 471 565 440 Bytes 471 563 200 Bytes -2.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pavelvelikhov pavelvelikhov merged commit 6a2d1fe into ydb-platform:main Jul 26, 2024
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 30, 2024
Merged
pavelvelikhov added a commit to pavelvelikhov/ydb that referenced this pull request Sep 5, 2024
@pavelvelikhov
Fixed a problem in RBO in MapJoin implementation (ydb-platform#7044)
e509c5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitstn vitstn vitstn approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelvelikhov @vitstn @gridnevvvit