Skip to content

YQ-3555 added validations on not existing for alter/drop object#7757

Merged
GrigoriyPA merged 2 commits intoydb-platform:mainfrom
GrigoriyPA:YQ-3555-add-error-for-alter-and-drop-for-not-found
Aug 15, 2024
Merged

YQ-3555 added validations on not existing for alter/drop object#7757
GrigoriyPA merged 2 commits intoydb-platform:mainfrom
GrigoriyPA:YQ-3555-add-error-for-alter-and-drop-for-not-found

Conversation

@GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Aug 14, 2024

Changelog entry

Added validations on not existing for alter/drop object

Changelog category

  • Improvement

Additional information

@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 06:21:25 UTC Pre-commit check for 7f23d86 has started.
⚪ 2024-08-14 06:24:07 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-14 06:32:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 06:21:34 UTC Pre-commit check for 7f23d86 has started.
⚪ 2024-08-14 06:24:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 08:31:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11009 10955 0 12 25 17

🟢 2024-08-14 08:32:37 UTC Build successful.
🟢 2024-08-14 08:33:06 UTC ydbd size 5.5 GiB changed* by +82.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8f1e398 merge: 7f23d86 diff diff %
ydbd size 5 855 154 312 Bytes 5 855 238 624 Bytes +82.3 KiB +0.001%
ydbd stripped size 1 470 040 944 Bytes 1 470 063 856 Bytes +22.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 06:21:42 UTC Pre-commit check for 7f23d86 has started.
⚪ 2024-08-14 06:24:28 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 07:43:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39837 34508 0 7 5308 14

⚪ 2024-08-14 07:48:25 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 07:57:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 9 0 5 1 11

⚪ 2024-08-14 07:57:24 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-14 08:06:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 6 0 5 0 11

🟢 2024-08-14 08:06:13 UTC Build successful.
🟢 2024-08-14 08:06:48 UTC ydbd size 8.1 GiB changed* by +62.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8f1e398 merge: 7f23d86 diff diff %
ydbd size 8 707 345 064 Bytes 8 707 409 496 Bytes +62.9 KiB +0.001%
ydbd stripped size 473 264 456 Bytes 473 269 448 Bytes +4.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA force-pushed the YQ-3555-add-error-for-alter-and-drop-for-not-found branch from b8d1b19 to 6c3a6ed Compare August 14, 2024 10:15
@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 10:19:02 UTC Pre-commit check for 7405459 has started.
⚪ 2024-08-14 10:21:41 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 12:21:16 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9735 9671 0 8 22 34

🟢 2024-08-14 12:22:23 UTC Build successful.
🟢 2024-08-14 12:22:52 UTC ydbd size 5.5 GiB changed* by +55.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9ec6f05 merge: 7405459 diff diff %
ydbd size 5 869 832 728 Bytes 5 869 889 392 Bytes +55.3 KiB +0.001%
ydbd stripped size 1 473 498 096 Bytes 1 473 509 392 Bytes +11.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 10:19:09 UTC Pre-commit check for 7405459 has started.
⚪ 2024-08-14 10:22:12 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-14 10:28:28 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 10:19:10 UTC Pre-commit check for 7405459 has started.
⚪ 2024-08-14 10:22:16 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-14 11:34:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13931 12554 0 4 1335 38

⚪ 2024-08-14 11:35:48 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-14 11:42:56 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 25 0 0 0 29

🟢 2024-08-14 11:43:04 UTC Build successful.
🟢 2024-08-14 11:43:41 UTC ydbd size 8.1 GiB changed* by +69.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9ec6f05 merge: 7405459 diff diff %
ydbd size 8 725 240 488 Bytes 8 725 311 736 Bytes +69.6 KiB +0.001%
ydbd stripped size 474 249 384 Bytes 474 251 624 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 13:41:53 UTC Pre-commit check for 2a115ae has started.
⚪ 2024-08-15 13:44:53 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-15 15:07:21 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 13:42:42 UTC Pre-commit check for 2a115ae has started.
⚪ 2024-08-15 13:46:08 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 14:26:15 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 13:43:16 UTC Pre-commit check for 2a115ae has started.
⚪ 2024-08-15 13:47:56 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-15 15:07:12 UTC Check cancelled

@GrigoriyPA GrigoriyPA force-pushed the YQ-3555-add-error-for-alter-and-drop-for-not-found branch from 940d7e9 to 7d5ba91 Compare August 15, 2024 15:06
@github-actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 15:17:01 UTC Pre-commit check for 2ddd853 has started.
⚪ 2024-08-15 15:20:19 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-15 16:04:08 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 15:30:54 UTC Pre-commit check for 2ddd853 has started.
⚪ 2024-08-15 15:34:46 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-15 17:13:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39904 34556 0 6 5309 33

⚪ 2024-08-15 17:16:52 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-15 17:25:38 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 23 0 0 0 28

🟢 2024-08-15 17:25:45 UTC Build successful.
🟡 2024-08-15 17:26:20 UTC ydbd size 8.1 GiB changed* by +910.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 929e8f5 merge: 2ddd853 diff diff %
ydbd size 8 731 908 688 Bytes 8 732 841 320 Bytes +910.8 KiB +0.011%
ydbd stripped size 475 258 760 Bytes 475 293 576 Bytes +34.0 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 15:42:47 UTC Pre-commit check for 2ddd853 has started.
⚪ 2024-08-15 15:46:19 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 18:12:02 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11065 11002 0 10 22 31

🟢 2024-08-15 18:12:59 UTC Build successful.
🟡 2024-08-15 18:13:25 UTC ydbd size 5.5 GiB changed* by +551.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 929e8f5 merge: 2ddd853 diff diff %
ydbd size 5 877 897 352 Bytes 5 878 461 856 Bytes +551.3 KiB +0.010%
ydbd stripped size 1 476 740 848 Bytes 1 476 857 488 Bytes +113.9 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 0b8a6e9 into ydb-platform:main Aug 15, 2024
@GrigoriyPA GrigoriyPA deleted the YQ-3555-add-error-for-alter-and-drop-for-not-found branch August 15, 2024 19:42
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 15, 2024
@GrigoriyPA
YQ-3555 added validations on not existing for alter/drop object (ydb-…
4dbe771 
…platform#7757)
This was referenced Aug 15, 2024
Closed
Merged
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 16, 2024
@GrigoriyPA
YQ-3555 added validations on not existing for alter/drop object (ydb-…
e5d97a4 
…platform#7757)
This was referenced Aug 19, 2024
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 21, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Aug 21, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 21, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@GrigoriyPA @stanislav-shchetinin
YQ-3555 added validations on not existing for alter/drop object (ydb-…
5b8d3e3 
…platform#7757)
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Sep 4, 2024
@GrigoriyPA
YQ-3555 added validations on not existing for alter/drop object (ydb-…
35b0b1f 
…platform#7757)
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 4, 2024
Merged
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Sep 9, 2024
@GrigoriyPA
YQ-3555 added validations on not existing for alter/drop object (ydb-…
aa593e9 
…platform#7757)
@niksaveliev niksaveliev mentioned this pull request Sep 9, 2024
Merged
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Sep 11, 2024
@GrigoriyPA
YQ-3555 added validations on not existing for alter/drop object (ydb-…
e4e878d 
…platform#7757)
@niksaveliev niksaveliev mentioned this pull request Sep 12, 2024
Merged
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Sep 17, 2024
@GrigoriyPA @uzhastik
YQ-3555 added validations on not existing for alter/drop object (ydb-…
d5bf3ed 
…platform#7757)
@StekPerepolnen StekPerepolnen mentioned this pull request Oct 29, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jan 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dorooleg dorooleg dorooleg approved these changes

@ivanmorozov333 ivanmorozov333 Awaiting requested review from ivanmorozov333

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GrigoriyPA @dorooleg