The code has been got rid of the TS3ReadActorFactoryConfig by dorooleg · Pull Request #8181 · ydb-platform/ydb

dorooleg · 2024-08-22T18:22:11Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-08-22T18:24:15Z

⚪ 2024-08-22 18:24:14 UTC Pre-commit check for f5f6408 has started.
⚪ 2024-08-22 18:28:08 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-22 20:17:52 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11378	11308	0	29	25	16

🟢 2024-08-22 20:18:51 UTC Build successful.
🟢 2024-08-22 20:19:20 UTC ydbd size 5.5 GiB changed* by -58.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `de42a46`	merge: `f5f6408`	diff	diff %
ydbd size	5 890 879 200 Bytes	5 890 819 192 Bytes	-58.6 KiB	-0.001%
ydbd stripped size	1 479 181 744 Bytes	1 479 163 472 Bytes	-17.8 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-22T18:25:31Z

⚪ 2024-08-22 18:25:30 UTC Pre-commit check for f5f6408 has started.
⚪ 2024-08-22 18:28:29 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-22 20:11:02 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40482	35138	0	10	5320	14

🟢 2024-08-22 20:14:32 UTC Build successful.
🟢 2024-08-22 20:15:10 UTC ydbd size 8.2 GiB changed* by -75.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `de42a46`	merge: `f5f6408`	diff	diff %
ydbd size	8 753 334 272 Bytes	8 753 257 368 Bytes	-75.1 KiB	-0.001%
ydbd stripped size	476 022 536 Bytes	476 017 928 Bytes	-4.5 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-08-22T18:25:35Z

⚪ 2024-08-22 18:25:35 UTC Pre-commit check for f5f6408 has started.
⚪ 2024-08-22 18:28:33 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-22 19:02:32 UTC Build successful.

uzhastik · 2024-08-22T18:26:07Z

 }

 message TReadActorsFactoryConfig {
-    TS3ReadActorFactoryConfig S3ReadActorFactoryConfig = 1;


Предлагаю сначала выпилить из всех конфигов, затем раскатать их на прод, потом уже удалять из прото

Да, так и хочу сделать. Подготовил отделное ревью для удаления конфигов https://a.yandex-team.ru/review/6585395/details. А это будет висеть пока в проде не обновим.

github-actions · 2024-09-04T12:58:14Z

⚪ 2024-09-04 12:58:14 UTC Pre-commit check linux-x86_64-release-clang14 for ac2d35c has started.
⚪ 2024-09-04 13:01:36 UTC ya make is running...
🟢 2024-09-04 13:44:45 UTC Build successful.

github-actions · 2024-09-04T12:58:53Z

⚪ 2024-09-04 12:58:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for ac2d35c has started.
⚪ 2024-09-04 13:02:06 UTC ya make is running...
🟡 2024-09-04 14:43:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40765	35323	0	11	5410	21

⚪ 2024-09-04 14:46:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-04 14:55:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
46 (only retried tests)	27	0	4	0	15

⚪ 2024-09-04 14:55:42 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-04 15:04:13 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
25 (only retried tests)	6	0	4	0	15

🟢 2024-09-04 15:04:21 UTC Build successful.
🟢 2024-09-04 15:05:03 UTC ydbd size 8.3 GiB changed* by -76.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `dd61f85`	merge: `ac2d35c`	diff	diff %
ydbd size	8 922 565 400 Bytes	8 922 487 152 Bytes	-76.4 KiB	-0.001%
ydbd stripped size	481 974 600 Bytes	481 969 928 Bytes	-4.6 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-04T13:03:56Z

⚪ 2024-09-04 13:03:55 UTC Pre-commit check linux-x86_64-release-asan for ac2d35c has started.
⚪ 2024-09-04 13:06:54 UTC ya make is running...
🔴 2024-09-04 15:18:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11521	11425	0	37	28	31

🟢 2024-09-04 15:19:50 UTC Build successful.
🟢 2024-09-04 15:20:21 UTC ydbd size 5.5 GiB changed* by -57.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `dd61f85`	merge: `ac2d35c`	diff	diff %
ydbd size	5 957 674 128 Bytes	5 957 615 368 Bytes	-57.4 KiB	-0.001%
ydbd stripped size	1 490 132 880 Bytes	1 490 114 352 Bytes	-18.1 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-05T09:01:16Z

⚪ 2024-09-05 09:01:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 168f726 has started.
⚪ 2024-09-05 09:04:17 UTC ya make is running...
🟡 2024-09-05 10:45:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40787	35337	0	9	5417	24

⚪ 2024-09-05 10:49:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-05 10:59:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
46 (only retried tests)	26	0	1	0	19

⚪ 2024-09-05 10:59:51 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-05 11:07:07 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
26 (only retried tests)	7	0	1	0	18

🟢 2024-09-05 11:07:16 UTC Build successful.
🟢 2024-09-05 11:07:52 UTC ydbd size 8.4 GiB changed* by -76.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `732bf12`	merge: `168f726`	diff	diff %
ydbd size	9 001 104 776 Bytes	9 001 026 528 Bytes	-76.4 KiB	-0.001%
ydbd stripped size	486 652 968 Bytes	486 648 296 Bytes	-4.6 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-05T09:01:47Z

⚪ 2024-09-05 09:01:46 UTC Pre-commit check linux-x86_64-release-clang14 for 168f726 has started.
⚪ 2024-09-05 09:04:57 UTC ya make is running...
🟢 2024-09-05 09:50:34 UTC Build successful.

github-actions · 2024-09-05T09:02:51Z

⚪ 2024-09-05 09:02:50 UTC Pre-commit check linux-x86_64-release-asan for 168f726 has started.
⚪ 2024-09-05 09:06:03 UTC ya make is running...
🔴 2024-09-05 11:25:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11539	11408	0	57	43	31

🟢 2024-09-05 11:26:16 UTC Build successful.
🟢 2024-09-05 11:26:49 UTC ydbd size 5.6 GiB changed* by -57.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `732bf12`	merge: `168f726`	diff	diff %
ydbd size	6 019 637 112 Bytes	6 019 578 328 Bytes	-57.4 KiB	-0.001%
ydbd stripped size	1 507 074 288 Bytes	1 507 055 760 Bytes	-18.1 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-05T13:17:18Z

⚪ 2024-09-05 13:17:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for c88a21d has started.
⚪ 2024-09-05 13:20:48 UTC ya make is running...
🟡 2024-09-05 15:00:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40788	35297	0	50	5418	23

⚪ 2024-09-05 15:04:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-05 15:14:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
85 (only retried tests)	40	0	27	0	18

⚪ 2024-09-05 15:14:19 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-05 15:21:09 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
50 (only retried tests)	32	0	0	0	18

🟢 2024-09-05 15:21:16 UTC Build successful.
🟢 2024-09-05 15:21:56 UTC ydbd size 8.4 GiB changed* by -76.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `b3e7ae5`	merge: `c88a21d`	diff	diff %
ydbd size	8 999 758 704 Bytes	8 999 680 512 Bytes	-76.4 KiB	-0.001%
ydbd stripped size	486 647 112 Bytes	486 642 504 Bytes	-4.5 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-05T13:17:54Z

⚪ 2024-09-05 13:17:54 UTC Pre-commit check linux-x86_64-release-clang14 for c88a21d has started.
⚪ 2024-09-05 13:21:20 UTC ya make is running...
🟢 2024-09-05 14:06:28 UTC Build successful.

github-actions · 2024-09-05T13:33:28Z

⚪ 2024-09-05 13:33:28 UTC Pre-commit check linux-x86_64-release-asan for c88a21d has started.
⚪ 2024-09-05 13:38:17 UTC ya make is running...
🔴 2024-09-05 15:41:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11541	11425	0	47	34	35

🟢 2024-09-05 15:42:26 UTC Build successful.
🟢 2024-09-05 15:42:56 UTC ydbd size 5.6 GiB changed* by -61.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `b3e7ae5`	merge: `c88a21d`	diff	diff %
ydbd size	6 017 775 712 Bytes	6 017 712 840 Bytes	-61.4 KiB	-0.001%
ydbd stripped size	1 507 082 096 Bytes	1 507 059 472 Bytes	-22.1 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

dorooleg · 2024-09-10T06:22:56Z

Проверил dqrun на локальных файлах, выглядит рабочим. мержу

The code has been got rid of the TS3ReadActorFactoryConfig

b469990

dorooleg requested a review from a team as a code owner August 22, 2024 18:22

github-actions bot added the not-for-changelog label Aug 22, 2024

uzhastik reviewed Aug 22, 2024

View reviewed changes

dorooleg added 3 commits September 4, 2024 11:35

The code has been got rid of the TS3ReadActorFactoryConfig

59ea971

cleanup

95ff029

run actor has been fixed

01d6e9b

dorooleg force-pushed the s3_read_actory_factory_config_got_rid_off branch from b469990 to 01d6e9b Compare September 4, 2024 12:53

dorooleg requested a review from a team as a code owner September 4, 2024 12:53

tests have been fixed

34b54e7

dorooleg added the rebase-and-check Rebase PR with the current base branch and check label Sep 5, 2024

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 5, 2024

uzhastik approved these changes Sep 6, 2024

View reviewed changes

resetius approved these changes Sep 9, 2024

View reviewed changes

dorooleg merged commit f30d481 into ydb-platform:main Sep 10, 2024

dorooleg deleted the s3_read_actory_factory_config_got_rid_off branch September 10, 2024 06:23

GrigoriyPA mentioned this pull request Sep 10, 2024

YQ kqprun fixed AS pools and added validations #9030

Merged

GrigoriyPA mentioned this pull request Sep 10, 2024

YQ-3653 added resource pools classifiers validations #9037

Merged

shnikd mentioned this pull request Sep 11, 2024

Long name domain test #9096

Closed

StekPerepolnen mentioned this pull request Sep 17, 2024

doc hc api images source #9376

Merged

Conversation

dorooleg commented Aug 22, 2024

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uzhastik Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

dorooleg Aug 23, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dorooleg commented Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Aug 22, 2024 •

edited

Loading

github-actions bot commented Aug 22, 2024 •

edited

Loading

github-actions bot commented Aug 22, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading