Skip to content

fix decimal output for builtin query requests#8950

Merged
adameat merged 1 commit intoydb-platform:mainfrom
adameat:fix-decimal
Sep 10, 2024
Merged

fix decimal output for builtin query requests#8950
adameat merged 1 commit intoydb-platform:mainfrom
adameat:fix-decimal

Conversation

@adameat
Copy link
Member

@adameat adameat commented Sep 9, 2024

Changelog entry

fix decimal output for builtin query requests
closes #8920

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

@adameat adameat requested a review from a team as a code owner September 9, 2024 11:53
@adameat adameat enabled auto-merge (squash) September 9, 2024 11:53
@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 11:54:38 UTC Pre-commit check linux-x86_64-release-clang14 for 69b4f26 has started.
2024-09-09 11:57:23 UTC ya make is running...
🟢 2024-09-09 12:04:47 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 11:59:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 69b4f26 has started.
2024-09-09 12:01:55 UTC ya make is running...
🟡 2024-09-09 13:00:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14360 12955 0 16 1366 23

2024-09-09 13:01:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-09 13:11:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 26 0 5 0 17

2024-09-09 13:11:35 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-09 13:18:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27 (only retried tests) 5 0 5 0 17

🟢 2024-09-09 13:18:56 UTC Build successful.
🟢 2024-09-09 13:19:39 UTC ydbd size 8.4 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d7a78d0 merge: 69b4f26 diff diff %
ydbd size 9 017 351 232 Bytes 9 017 351 248 Bytes +16 Bytes +0.000%
ydbd stripped size 487 427 464 Bytes 487 427 592 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 11:59:33 UTC Pre-commit check linux-x86_64-release-asan for 69b4f26 has started.
2024-09-09 12:02:15 UTC ya make is running...
🔴 2024-09-09 14:05:24 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9921 9787 0 54 39 41

🟢 2024-09-09 14:06:17 UTC Build successful.
🟢 2024-09-09 14:06:50 UTC ydbd size 5.6 GiB changed* by +288 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d7a78d0 merge: 69b4f26 diff diff %
ydbd size 6 032 166 104 Bytes 6 032 166 392 Bytes +288 Bytes +0.000%
ydbd stripped size 1 510 171 088 Bytes 1 510 171 216 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
@github-actions
Copy link

2024-09-10 05:44:49 UTC Pre-commit check linux-x86_64-release-clang14 for 3378906 has started.

@github-actions
Copy link

2024-09-10 05:44:49 UTC Pre-commit check linux-x86_64-release-asan for 3378906 has started.

@github-actions
Copy link

2024-09-10 05:46:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3378906 has started.

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Sep 10, 2024
@github-actions
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:32:35 UTC Pre-commit check linux-x86_64-release-asan for 69a614b has started.
2024-09-10 08:35:30 UTC ya make is running...
🔴 2024-09-10 10:10:56 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9912 9833 0 18 28 33

🟢 2024-09-10 10:11:49 UTC Build successful.
🟢 2024-09-10 10:12:22 UTC ydbd size 5.6 GiB changed* by +288 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4a8eeda merge: 69a614b diff diff %
ydbd size 6 036 912 800 Bytes 6 036 913 088 Bytes +288 Bytes +0.000%
ydbd stripped size 1 511 084 976 Bytes 1 511 085 104 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:32:47 UTC Pre-commit check linux-x86_64-release-clang14 for 69a614b has started.
2024-09-10 08:37:10 UTC ya make is running...
🟢 2024-09-10 08:43:53 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 10, 2024

2024-09-10 08:34:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 69a614b has started.
2024-09-10 08:37:26 UTC ya make is running...
🟡 2024-09-10 09:33:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14367 12919 0 23 1400 25

2024-09-10 09:35:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-10 09:46:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
84 (only retried tests) 63 0 1 0 20

2024-09-10 09:46:26 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-10 09:53:40 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25 (only retried tests) 7 0 0 0 18

🟢 2024-09-10 09:53:47 UTC Build successful.
🟢 2024-09-10 09:54:28 UTC ydbd size 8.4 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4a8eeda merge: 69a614b diff diff %
ydbd size 9 024 182 440 Bytes 9 024 182 392 Bytes -48 Bytes -0.000%
ydbd stripped size 487 703 400 Bytes 487 703 464 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit f38e450 into ydb-platform:main Sep 10, 2024
@shnikd shnikd mentioned this pull request Sep 11, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024
@adameat adameat deleted the fix-decimal branch November 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect decimal values visualization of column tables in web UI

2 participants