Skip to content

Add incremental restore type in ChangeExchange#8986

Merged
Enjection merged 1 commit intoydb-platform:mainfrom
Enjection:feature/backups/allow-empty-step-txid
Sep 9, 2024
Merged

Add incremental restore type in ChangeExchange#8986
Enjection merged 1 commit intoydb-platform:mainfrom
Enjection:feature/backups/allow-empty-step-txid

Conversation

@Enjection
Copy link
Member

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 16:12:33 UTC Pre-commit check linux-x86_64-release-asan for 35cca30 has started.
2024-09-09 16:16:36 UTC ya make is running...
🔴 2024-09-09 17:54:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11378 11313 0 15 23 27

🟢 2024-09-09 17:55:24 UTC Build successful.
🟢 2024-09-09 17:55:54 UTC ydbd size 5.6 GiB changed* by +5.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d22f086 merge: 35cca30 diff diff %
ydbd size 6 036 482 440 Bytes 6 036 487 864 Bytes +5.3 KiB +0.000%
ydbd stripped size 1 511 083 248 Bytes 1 511 083 248 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 16:15:00 UTC Pre-commit check linux-x86_64-release-clang14 for 35cca30 has started.
2024-09-09 16:18:15 UTC ya make is running...
🟢 2024-09-09 16:27:54 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

2024-09-09 16:18:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 35cca30 has started.
2024-09-09 16:21:07 UTC ya make is running...
🟡 2024-09-09 17:36:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40628 35169 0 7 5431 21

2024-09-09 17:39:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-09 17:47:32 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38 (only retried tests) 20 0 0 1 17

🟢 2024-09-09 17:47:38 UTC Build successful.
🟢 2024-09-09 17:48:17 UTC ydbd size 8.4 GiB changed* by +16.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d22f086 merge: 35cca30 diff diff %
ydbd size 9 023 440 064 Bytes 9 023 456 960 Bytes +16.5 KiB +0.000%
ydbd stripped size 487 701 480 Bytes 487 702 120 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Enjection Enjection requested a review from CyberROFL September 9, 2024 17:58
return record.GetKindCase() == NKikimrChangeExchange::TChangeRecord::kAsyncIndex;
}

static bool ValidChangeKind(const NKikimrChangeExchange::TChangeRecord& record) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может IsValidChangeKind?

@Enjection Enjection merged commit 68b5a8d into ydb-platform:main Sep 9, 2024
@Enjection Enjection deleted the feature/backups/allow-empty-step-txid branch September 9, 2024 20:26
@shnikd shnikd mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants