Balancing: add new limits, timeouts and sensors, fix blob on main by ingress, but not realy#9239
Conversation
robdrynkin
commented
Sep 13, 2024
- Not for changelog (changelog entry is not required)
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| merger.Clear(); | ||
|
|
||
| if (SendOnMainParts.Size() >= MAX_TO_SEND_PER_EPOCH && TryDeleteParts.Size() >= MAX_TO_DELETE_PER_EPOCH) { |
There was a problem hiding this comment.
maybe || ?
if any of limits is exceeded actor should stop.
There was a problem hiding this comment.
No, thats not a mistake, I check TryDeleteParts.Size() < MAX_TO_DELETE_PER_EPOCH and SendOnMainParts.Size() < MAX_TO_SEND_PER_EPOCH above before pushing to queues. If I will check ||, there could be a situation when I will only send parts on main for a long time, without deletes
…ingress, but not realy (ydb-platform#9239)