Skip to content

Better interrupts + node sorting#96

Merged
Jorres merged 7 commits into
masterfrom
rack-aware-sorting
Jun 14, 2026
Merged

Better interrupts + node sorting#96
Jorres merged 7 commits into
masterfrom
rack-aware-sorting

Conversation

@Jorres

@Jorres Jorres commented May 6, 2026

Copy link
Copy Markdown
Contributor

Several quality of life changes:

  • [bugfix] add transport-layer timeouts to avoid stuck grpc connections
  • [bugfix] ctrl+c now interrupts correctly (previously not all points were interruptible and that led to delays depending on parameters, up to 30s with defaults)
  • [no-config feature] an attempt to optimize per-tenant restart: assuming that CMS tries to give nodes in the order of submission, sorting round-robin by tenants gave a speedup (it was actually considered back when per tenant restart was implemented but due to human error didnt go into [NBYDBOPS-1669] add support for parallel tenant nodes restart #81 previous PR)
  • [no-config feature] soft-prefer to restart nodes from a single failure domain (compared to just strict node-id sorting)
  • new tests for all the above

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

Comment thread pkg/utils/retries.go
Comment thread pkg/utils/retries.go
Comment thread pkg/utils/retries_test.go
Comment thread pkg/rolling/restarters/primitives.go Outdated
Comment thread pkg/client/cms/cms.go Outdated
Comment thread pkg/client/cms/cms.go
@Jorres Jorres changed the title Rack aware sorting Better interrupts + node sorting Jun 13, 2026
@Jorres Jorres merged commit c39cc48 into master Jun 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants